public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: YueHaibing <yuehaibing@huawei.com>,
	rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org,
	rui.zhang@intel.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] thermal: int340x: processor_thermal: Fix build error
Date: Thu, 11 Nov 2021 06:51:21 -0800	[thread overview]
Message-ID: <b91c26d828b24479369fa1f17d8d03c324b5bebd.camel@linux.intel.com> (raw)
In-Reply-To: <20211111070716.20260-1-yuehaibing@huawei.com>

On Thu, 2021-11-11 at 15:07 +0800, YueHaibing wrote:
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In
> function ‘send_mbox_cmd’:
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16:
>  error: implicit declaration of function ‘readq’; did you mean
> ‘readl’? [-Werror=implicit-function-declaration]
>     *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base +
> MBOX_OFFSET_DATA));
>                 ^~~~~
>                 readl
> 
> Add missing include to fix this.
Have you checked a patch titled "thermal/drivers/int340x: limit Kconfig
to 64-bit"?

Thanks,
Srinivas

> 
> Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal:
> Suppot 64 bit RFIM responses")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git
> a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> index a86521973dad..01008ae00e7f 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> @@ -7,6 +7,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> +#include <linux/io-64-nonatomic-lo-hi.h>
>  #include "processor_thermal_device.h"
>  
>  #define MBOX_CMD_WORKLOAD_TYPE_READ    0x0E



  reply	other threads:[~2021-11-11 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  7:07 [PATCH -next] thermal: int340x: processor_thermal: Fix build error YueHaibing
2021-11-11 14:51 ` Srinivas Pandruvada [this message]
2021-11-12  2:16   ` YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b91c26d828b24479369fa1f17d8d03c324b5bebd.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox