* [PATCH -next] thermal: int340x: processor_thermal: Fix build error
@ 2021-11-11 7:07 YueHaibing
2021-11-11 14:51 ` Srinivas Pandruvada
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2021-11-11 7:07 UTC (permalink / raw)
To: rafael, daniel.lezcano, amitk, rui.zhang, srinivas.pandruvada
Cc: linux-pm, linux-kernel, YueHaibing
drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In function ‘send_mbox_cmd’:
drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16:
error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration]
*cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA));
^~~~~
readl
Add missing include to fix this.
Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal: Suppot 64 bit RFIM responses")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
index a86521973dad..01008ae00e7f 100644
--- a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
+++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
@@ -7,6 +7,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/pci.h>
+#include <linux/io-64-nonatomic-lo-hi.h>
#include "processor_thermal_device.h"
#define MBOX_CMD_WORKLOAD_TYPE_READ 0x0E
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] thermal: int340x: processor_thermal: Fix build error
2021-11-11 7:07 [PATCH -next] thermal: int340x: processor_thermal: Fix build error YueHaibing
@ 2021-11-11 14:51 ` Srinivas Pandruvada
2021-11-12 2:16 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Pandruvada @ 2021-11-11 14:51 UTC (permalink / raw)
To: YueHaibing, rafael, daniel.lezcano, amitk, rui.zhang
Cc: linux-pm, linux-kernel
On Thu, 2021-11-11 at 15:07 +0800, YueHaibing wrote:
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In
> function ‘send_mbox_cmd’:
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16:
> error: implicit declaration of function ‘readq’; did you mean
> ‘readl’? [-Werror=implicit-function-declaration]
> *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base +
> MBOX_OFFSET_DATA));
> ^~~~~
> readl
>
> Add missing include to fix this.
Have you checked a patch titled "thermal/drivers/int340x: limit Kconfig
to 64-bit"?
Thanks,
Srinivas
>
> Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal:
> Suppot 64 bit RFIM responses")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> index a86521973dad..01008ae00e7f 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
> @@ -7,6 +7,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> +#include <linux/io-64-nonatomic-lo-hi.h>
> #include "processor_thermal_device.h"
>
> #define MBOX_CMD_WORKLOAD_TYPE_READ 0x0E
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] thermal: int340x: processor_thermal: Fix build error
2021-11-11 14:51 ` Srinivas Pandruvada
@ 2021-11-12 2:16 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2021-11-12 2:16 UTC (permalink / raw)
To: Srinivas Pandruvada, rafael, daniel.lezcano, amitk, rui.zhang
Cc: linux-pm, linux-kernel
On 2021/11/11 22:51, Srinivas Pandruvada wrote:
> On Thu, 2021-11-11 at 15:07 +0800, YueHaibing wrote:
>> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In
>> function ‘send_mbox_cmd’:
>> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16:
>> error: implicit declaration of function ‘readq’; did you mean
>> ‘readl’? [-Werror=implicit-function-declaration]
>> *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base +
>> MBOX_OFFSET_DATA));
>> ^~~~~
>> readl
>>
>> Add missing include to fix this.
> Have you checked a patch titled "thermal/drivers/int340x: limit Kconfig
> to 64-bit"?
Thanks for your info, the patch fix the issue.
>
> Thanks,
> Srinivas
>
>>
>> Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal:
>> Suppot 64 bit RFIM responses")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
>> b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
>> index a86521973dad..01008ae00e7f 100644
>> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
>> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c
>> @@ -7,6 +7,7 @@
>> #include <linux/kernel.h>
>> #include <linux/module.h>
>> #include <linux/pci.h>
>> +#include <linux/io-64-nonatomic-lo-hi.h>
>> #include "processor_thermal_device.h"
>>
>> #define MBOX_CMD_WORKLOAD_TYPE_READ 0x0E
>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-12 2:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-11 7:07 [PATCH -next] thermal: int340x: processor_thermal: Fix build error YueHaibing
2021-11-11 14:51 ` Srinivas Pandruvada
2021-11-12 2:16 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox