amd-pstate 6.13 content (10/22/24)

amd-pstate 6.13 content (10/22/24)

[Mario Limonciello]

Hello,

The following changes since commit 7f31183fa1d5c043864b4bd5632930f40d3c7002:

   Merge branch 'acpi-battery' into linux-next (2024-10-22 22:00:30 +0200)

are available in the Git repository at:

  
ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git 
tags/amd-pstate-v6.13-2024-10-22

for you to fetch changes up to 7027b415ff1a4184b99055f11455d5c7041aa3ee:

   cpufreq/amd-pstate-ut: Add fix for min freq unit test (2024-10-22 
15:21:42 -0500)

----------------------------------------------------------------
Update the amd-pstate driver to set the initial scaling frequency policy
lower bound to be lowest non-linear frequency. This will have a slight
power consumption impact but should lead to increased efficiency.

Also amd-pstate is enabled by default on servers starting with newer
AMD Epyc processors.

Add various code cleanups to rename functions and remove redundant calls.

----------------------------------------------------------------
Dhananjay Ugwekar (7):
       cpufreq/amd-pstate: Rename MSR and shared memory specific functions
       cpufreq/amd-pstate: Remove the redundant verify() function
       cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq
       cpufreq/amd-pstate: Call amd_pstate_register() in amd_pstate_init()
       cpufreq/amd-pstate: Call amd_pstate_set_driver() in 
amd_pstate_register_driver()
       cpufreq/amd-pstate: Remove the switch case in amd_pstate_init()
       cpufreq/amd-pstate: Remove the redundant amd_pstate_set_driver() call

Gautham R. Shenoy (1):
       amd-pstate: Set min_perf to nominal_perf for active mode 
performance gov

Mario Limonciello (5):
       cpufreq/amd-pstate: Fix non kerneldoc comment
       cpufreq/amd-pstate: Don't update CPPC request in 
amd_pstate_cpu_boost_update()
       cpufreq/amd-pstate: Use amd_pstate_update_min_max_limit() for EPP 
limits
       cpufreq/amd-pstate: Drop needless EPP initialization
       cpufreq/amd-pstate-ut: Add fix for min freq unit test

Swapnil Sapkal (1):
       amd-pstate: Switch to amd-pstate by default on some Server platforms

Re: amd-pstate 6.13 content (10/22/24)

[Rafael J. Wysocki]

Hi,

On Tue, Oct 22, 2024 at 10:54 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> Hello,
>
> The following changes since commit 7f31183fa1d5c043864b4bd5632930f40d3c7002:
>
>    Merge branch 'acpi-battery' into linux-next (2024-10-22 22:00:30 +0200)
>
> are available in the Git repository at:
>
>
> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git
> tags/amd-pstate-v6.13-2024-10-22
>
> for you to fetch changes up to 7027b415ff1a4184b99055f11455d5c7041aa3ee:
>
>    cpufreq/amd-pstate-ut: Add fix for min freq unit test (2024-10-22
> 15:21:42 -0500)
>
> ----------------------------------------------------------------
> Update the amd-pstate driver to set the initial scaling frequency policy
> lower bound to be lowest non-linear frequency. This will have a slight
> power consumption impact but should lead to increased efficiency.
>
> Also amd-pstate is enabled by default on servers starting with newer
> AMD Epyc processors.
>
> Add various code cleanups to rename functions and remove redundant calls.
>
> ----------------------------------------------------------------
> Dhananjay Ugwekar (7):
>        cpufreq/amd-pstate: Rename MSR and shared memory specific functions
>        cpufreq/amd-pstate: Remove the redundant verify() function
>        cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq
>        cpufreq/amd-pstate: Call amd_pstate_register() in amd_pstate_init()
>        cpufreq/amd-pstate: Call amd_pstate_set_driver() in
> amd_pstate_register_driver()
>        cpufreq/amd-pstate: Remove the switch case in amd_pstate_init()
>        cpufreq/amd-pstate: Remove the redundant amd_pstate_set_driver() call
>
> Gautham R. Shenoy (1):
>        amd-pstate: Set min_perf to nominal_perf for active mode
> performance gov
>
> Mario Limonciello (5):
>        cpufreq/amd-pstate: Fix non kerneldoc comment
>        cpufreq/amd-pstate: Don't update CPPC request in
> amd_pstate_cpu_boost_update()
>        cpufreq/amd-pstate: Use amd_pstate_update_min_max_limit() for EPP
> limits
>        cpufreq/amd-pstate: Drop needless EPP initialization
>        cpufreq/amd-pstate-ut: Add fix for min freq unit test
>
> Swapnil Sapkal (1):
>        amd-pstate: Switch to amd-pstate by default on some Server platforms

Pulled, thanks!

Re: amd-pstate 6.13 content (10/22/24)

[Rafael J. Wysocki]

On Wed, Oct 23, 2024 at 3:16 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> Hi,
>
> On Tue, Oct 22, 2024 at 10:54 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
> >
> > Hello,
> >
> > The following changes since commit 7f31183fa1d5c043864b4bd5632930f40d3c7002:
> >
> >    Merge branch 'acpi-battery' into linux-next (2024-10-22 22:00:30 +0200)
> >
> > are available in the Git repository at:
> >
> >
> > ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git
> > tags/amd-pstate-v6.13-2024-10-22
> >
> > for you to fetch changes up to 7027b415ff1a4184b99055f11455d5c7041aa3ee:
> >
> >    cpufreq/amd-pstate-ut: Add fix for min freq unit test (2024-10-22
> > 15:21:42 -0500)
> >
> > ----------------------------------------------------------------
> > Update the amd-pstate driver to set the initial scaling frequency policy
> > lower bound to be lowest non-linear frequency. This will have a slight
> > power consumption impact but should lead to increased efficiency.
> >
> > Also amd-pstate is enabled by default on servers starting with newer
> > AMD Epyc processors.
> >
> > Add various code cleanups to rename functions and remove redundant calls.
> >
> > ----------------------------------------------------------------
> > Dhananjay Ugwekar (7):
> >        cpufreq/amd-pstate: Rename MSR and shared memory specific functions
> >        cpufreq/amd-pstate: Remove the redundant verify() function
> >        cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq
> >        cpufreq/amd-pstate: Call amd_pstate_register() in amd_pstate_init()
> >        cpufreq/amd-pstate: Call amd_pstate_set_driver() in
> > amd_pstate_register_driver()
> >        cpufreq/amd-pstate: Remove the switch case in amd_pstate_init()
> >        cpufreq/amd-pstate: Remove the redundant amd_pstate_set_driver() call
> >
> > Gautham R. Shenoy (1):
> >        amd-pstate: Set min_perf to nominal_perf for active mode
> > performance gov
> >
> > Mario Limonciello (5):
> >        cpufreq/amd-pstate: Fix non kerneldoc comment
> >        cpufreq/amd-pstate: Don't update CPPC request in
> > amd_pstate_cpu_boost_update()
> >        cpufreq/amd-pstate: Use amd_pstate_update_min_max_limit() for EPP
> > limits
> >        cpufreq/amd-pstate: Drop needless EPP initialization
> >        cpufreq/amd-pstate-ut: Add fix for min freq unit test
> >
> > Swapnil Sapkal (1):
> >        amd-pstate: Switch to amd-pstate by default on some Server platforms
>
> Pulled, thanks!

And unpulled, because this branch contains my temporary linux-next merges.

Please.  If you want my branch to base your material on, let me know
and I'll create one for you.  Otherwise, please base your material
that you are going to push to me on an -rc from Linus.

Thanks!

Re: amd-pstate 6.13 content (10/22/24)

[Mario Limonciello]

On 10/28/2024 06:22, Rafael J. Wysocki wrote:
> On Wed, Oct 23, 2024 at 3:16 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>
>> Hi,
>>
>> On Tue, Oct 22, 2024 at 10:54 PM Mario Limonciello
>> <mario.limonciello@amd.com> wrote:
>>>
>>> Hello,
>>>
>>> The following changes since commit 7f31183fa1d5c043864b4bd5632930f40d3c7002:
>>>
>>>     Merge branch 'acpi-battery' into linux-next (2024-10-22 22:00:30 +0200)
>>>
>>> are available in the Git repository at:
>>>
>>>
>>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git
>>> tags/amd-pstate-v6.13-2024-10-22
>>>
>>> for you to fetch changes up to 7027b415ff1a4184b99055f11455d5c7041aa3ee:
>>>
>>>     cpufreq/amd-pstate-ut: Add fix for min freq unit test (2024-10-22
>>> 15:21:42 -0500)
>>>
>>> ----------------------------------------------------------------
>>> Update the amd-pstate driver to set the initial scaling frequency policy
>>> lower bound to be lowest non-linear frequency. This will have a slight
>>> power consumption impact but should lead to increased efficiency.
>>>
>>> Also amd-pstate is enabled by default on servers starting with newer
>>> AMD Epyc processors.
>>>
>>> Add various code cleanups to rename functions and remove redundant calls.
>>>
>>> ----------------------------------------------------------------
>>> Dhananjay Ugwekar (7):
>>>         cpufreq/amd-pstate: Rename MSR and shared memory specific functions
>>>         cpufreq/amd-pstate: Remove the redundant verify() function
>>>         cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq
>>>         cpufreq/amd-pstate: Call amd_pstate_register() in amd_pstate_init()
>>>         cpufreq/amd-pstate: Call amd_pstate_set_driver() in
>>> amd_pstate_register_driver()
>>>         cpufreq/amd-pstate: Remove the switch case in amd_pstate_init()
>>>         cpufreq/amd-pstate: Remove the redundant amd_pstate_set_driver() call
>>>
>>> Gautham R. Shenoy (1):
>>>         amd-pstate: Set min_perf to nominal_perf for active mode
>>> performance gov
>>>
>>> Mario Limonciello (5):
>>>         cpufreq/amd-pstate: Fix non kerneldoc comment
>>>         cpufreq/amd-pstate: Don't update CPPC request in
>>> amd_pstate_cpu_boost_update()
>>>         cpufreq/amd-pstate: Use amd_pstate_update_min_max_limit() for EPP
>>> limits
>>>         cpufreq/amd-pstate: Drop needless EPP initialization
>>>         cpufreq/amd-pstate-ut: Add fix for min freq unit test
>>>
>>> Swapnil Sapkal (1):
>>>         amd-pstate: Switch to amd-pstate by default on some Server platforms
>>
>> Pulled, thanks!
> 
> And unpulled, because this branch contains my temporary linux-next merges.
> 
> Please.  If you want my branch to base your material on, let me know
> and I'll create one for you.  Otherwise, please base your material
> that you are going to push to me on an -rc from Linus.
> 
> Thanks!

I had asked if I could base on your linux-next before sending it.

Yes; in this case can you please make a base branch instead and I'll 
send out a new one then based on that.

Re: amd-pstate 6.13 content (10/22/24)

[Rafael J. Wysocki]

On Mon, Oct 28, 2024 at 2:56 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 10/28/2024 06:22, Rafael J. Wysocki wrote:
> > On Wed, Oct 23, 2024 at 3:16 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >>
> >> Hi,
> >>
> >> On Tue, Oct 22, 2024 at 10:54 PM Mario Limonciello
> >> <mario.limonciello@amd.com> wrote:
> >>>
> >>> Hello,
> >>>
> >>> The following changes since commit 7f31183fa1d5c043864b4bd5632930f40d3c7002:
> >>>
> >>>     Merge branch 'acpi-battery' into linux-next (2024-10-22 22:00:30 +0200)
> >>>
> >>> are available in the Git repository at:
> >>>
> >>>
> >>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git
> >>> tags/amd-pstate-v6.13-2024-10-22
> >>>
> >>> for you to fetch changes up to 7027b415ff1a4184b99055f11455d5c7041aa3ee:
> >>>
> >>>     cpufreq/amd-pstate-ut: Add fix for min freq unit test (2024-10-22
> >>> 15:21:42 -0500)
> >>>
> >>> ----------------------------------------------------------------
> >>> Update the amd-pstate driver to set the initial scaling frequency policy
> >>> lower bound to be lowest non-linear frequency. This will have a slight
> >>> power consumption impact but should lead to increased efficiency.
> >>>
> >>> Also amd-pstate is enabled by default on servers starting with newer
> >>> AMD Epyc processors.
> >>>
> >>> Add various code cleanups to rename functions and remove redundant calls.
> >>>
> >>> ----------------------------------------------------------------
> >>> Dhananjay Ugwekar (7):
> >>>         cpufreq/amd-pstate: Rename MSR and shared memory specific functions
> >>>         cpufreq/amd-pstate: Remove the redundant verify() function
> >>>         cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq
> >>>         cpufreq/amd-pstate: Call amd_pstate_register() in amd_pstate_init()
> >>>         cpufreq/amd-pstate: Call amd_pstate_set_driver() in
> >>> amd_pstate_register_driver()
> >>>         cpufreq/amd-pstate: Remove the switch case in amd_pstate_init()
> >>>         cpufreq/amd-pstate: Remove the redundant amd_pstate_set_driver() call
> >>>
> >>> Gautham R. Shenoy (1):
> >>>         amd-pstate: Set min_perf to nominal_perf for active mode
> >>> performance gov
> >>>
> >>> Mario Limonciello (5):
> >>>         cpufreq/amd-pstate: Fix non kerneldoc comment
> >>>         cpufreq/amd-pstate: Don't update CPPC request in
> >>> amd_pstate_cpu_boost_update()
> >>>         cpufreq/amd-pstate: Use amd_pstate_update_min_max_limit() for EPP
> >>> limits
> >>>         cpufreq/amd-pstate: Drop needless EPP initialization
> >>>         cpufreq/amd-pstate-ut: Add fix for min freq unit test
> >>>
> >>> Swapnil Sapkal (1):
> >>>         amd-pstate: Switch to amd-pstate by default on some Server platforms
> >>
> >> Pulled, thanks!
> >
> > And unpulled, because this branch contains my temporary linux-next merges.
> >
> > Please.  If you want my branch to base your material on, let me know
> > and I'll create one for you.  Otherwise, please base your material
> > that you are going to push to me on an -rc from Linus.
> >
> > Thanks!
>
> I had asked if I could base on your linux-next before sending it.

I obviously missed or misunderstood it, sorry.

The rule of thumb is that all merges in my fixes, linux-next, testing
and bleeding-edge branches are temporary and they cannot show up in
the mainline.

So I wouldn't have been able to ask Linus to pull any branch
containing any of these merges.

> Yes; in this case can you please make a base branch instead and I'll
> send out a new one then based on that.

Please use the 'cpufreq' branch:

git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git cpufreq

that I've just pushed.

Thanks!

Re: amd-pstate 6.13 content (10/22/24)

[Mario Limonciello]

On 10/28/2024 10:21, Rafael J. Wysocki wrote:
> On Mon, Oct 28, 2024 at 2:56 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>> On 10/28/2024 06:22, Rafael J. Wysocki wrote:
>>> On Wed, Oct 23, 2024 at 3:16 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>>>
>>>> Hi,
>>>>
>>>> On Tue, Oct 22, 2024 at 10:54 PM Mario Limonciello
>>>> <mario.limonciello@amd.com> wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> The following changes since commit 7f31183fa1d5c043864b4bd5632930f40d3c7002:
>>>>>
>>>>>      Merge branch 'acpi-battery' into linux-next (2024-10-22 22:00:30 +0200)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>
>>>>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git
>>>>> tags/amd-pstate-v6.13-2024-10-22
>>>>>
>>>>> for you to fetch changes up to 7027b415ff1a4184b99055f11455d5c7041aa3ee:
>>>>>
>>>>>      cpufreq/amd-pstate-ut: Add fix for min freq unit test (2024-10-22
>>>>> 15:21:42 -0500)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Update the amd-pstate driver to set the initial scaling frequency policy
>>>>> lower bound to be lowest non-linear frequency. This will have a slight
>>>>> power consumption impact but should lead to increased efficiency.
>>>>>
>>>>> Also amd-pstate is enabled by default on servers starting with newer
>>>>> AMD Epyc processors.
>>>>>
>>>>> Add various code cleanups to rename functions and remove redundant calls.
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Dhananjay Ugwekar (7):
>>>>>          cpufreq/amd-pstate: Rename MSR and shared memory specific functions
>>>>>          cpufreq/amd-pstate: Remove the redundant verify() function
>>>>>          cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq
>>>>>          cpufreq/amd-pstate: Call amd_pstate_register() in amd_pstate_init()
>>>>>          cpufreq/amd-pstate: Call amd_pstate_set_driver() in
>>>>> amd_pstate_register_driver()
>>>>>          cpufreq/amd-pstate: Remove the switch case in amd_pstate_init()
>>>>>          cpufreq/amd-pstate: Remove the redundant amd_pstate_set_driver() call
>>>>>
>>>>> Gautham R. Shenoy (1):
>>>>>          amd-pstate: Set min_perf to nominal_perf for active mode
>>>>> performance gov
>>>>>
>>>>> Mario Limonciello (5):
>>>>>          cpufreq/amd-pstate: Fix non kerneldoc comment
>>>>>          cpufreq/amd-pstate: Don't update CPPC request in
>>>>> amd_pstate_cpu_boost_update()
>>>>>          cpufreq/amd-pstate: Use amd_pstate_update_min_max_limit() for EPP
>>>>> limits
>>>>>          cpufreq/amd-pstate: Drop needless EPP initialization
>>>>>          cpufreq/amd-pstate-ut: Add fix for min freq unit test
>>>>>
>>>>> Swapnil Sapkal (1):
>>>>>          amd-pstate: Switch to amd-pstate by default on some Server platforms
>>>>
>>>> Pulled, thanks!
>>>
>>> And unpulled, because this branch contains my temporary linux-next merges.
>>>
>>> Please.  If you want my branch to base your material on, let me know
>>> and I'll create one for you.  Otherwise, please base your material
>>> that you are going to push to me on an -rc from Linus.
>>>
>>> Thanks!
>>
>> I had asked if I could base on your linux-next before sending it.
> 
> I obviously missed or misunderstood it, sorry.
> 
> The rule of thumb is that all merges in my fixes, linux-next, testing
> and bleeding-edge branches are temporary and they cannot show up in
> the mainline.
> 
> So I wouldn't have been able to ask Linus to pull any branch
> containing any of these merges.
> 
>> Yes; in this case can you please make a base branch instead and I'll
>> send out a new one then based on that.
> 
> Please use the 'cpufreq' branch:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git cpufreq
> 
> that I've just pushed.
> 
> Thanks!

Thanks!  I'll send you a new PR later this week so I can pick up the 
other fixes still under discussion.