From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
ulf.hansson@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: agross@kernel.org, conor+dt@kernel.org, quic_rjendra@quicinc.com,
abel.vesa@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, quic_tsoni@quicinc.com,
neil.armstrong@linaro.org
Subject: Re: [PATCH 2/2] pmdomain: qcom: rpmhpd: Update part number to X1E80100
Date: Fri, 17 Nov 2023 13:40:09 +0100 [thread overview]
Message-ID: <bf7c7478-a7f3-4dca-b329-7771f3dbcd30@linaro.org> (raw)
In-Reply-To: <2965dbc9-2e19-5bc1-dfde-a0b821fd5a59@quicinc.com>
On 17/11/2023 12:50, Sibi Sankar wrote:
> Hey Krzysztof,
>
>
> On 11/17/23 16:36, Krzysztof Kozlowski wrote:
>> On 17/11/2023 11:42, Sibi Sankar wrote:
>>> Replace SC8380xp with the updated part number (X1E80100).
>>>
>>> Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains")
>>
>> No, there was no bug or at least you did not describe a bug. If it was a
>> bug, please define it in the commit msg.
>
> It's technically replacing an obsolete part number with the correct
> on, so I thought using the fixes tag makes sense. Let me add more
> details on the next re-spin.
You are not replacing any obsolete device. It's purely naming style, so
no, that's not a valid reason for a fix. Drop fixes tag from both patches.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-11-17 12:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 10:42 [PATCH 0/2] pmdomain: qcom: Update part number to X1E80100 Sibi Sankar
2023-11-17 10:42 ` [PATCH 1/2] dt-bindings: power: rpmpd: " Sibi Sankar
2023-11-17 11:05 ` Krzysztof Kozlowski
2023-11-17 11:46 ` Sibi Sankar
2023-11-17 12:39 ` Krzysztof Kozlowski
2023-11-17 23:40 ` Konrad Dybcio
2023-11-20 6:52 ` Sibi Sankar
2023-11-17 10:42 ` [PATCH 2/2] pmdomain: qcom: rpmhpd: " Sibi Sankar
2023-11-17 11:06 ` Krzysztof Kozlowski
2023-11-17 11:50 ` Sibi Sankar
2023-11-17 12:40 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf7c7478-a7f3-4dca-b329-7771f3dbcd30@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox