From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
andersson@kernel.org, ulf.hansson@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: agross@kernel.org, conor+dt@kernel.org, quic_rjendra@quicinc.com,
abel.vesa@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, quic_tsoni@quicinc.com,
neil.armstrong@linaro.org
Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100
Date: Sat, 18 Nov 2023 00:40:13 +0100 [thread overview]
Message-ID: <796fd7be-2008-460e-acf7-e335de780104@linaro.org> (raw)
In-Reply-To: <81a1bfee-851c-4f05-b816-47abcebed99c@linaro.org>
On 17.11.2023 13:39, Krzysztof Kozlowski wrote:
> On 17/11/2023 12:46, Sibi Sankar wrote:
>> Hey Krzysztof,
>>
>> Thanks for taking time to review the series.
>>
>> On 11/17/23 16:35, Krzysztof Kozlowski wrote:
>>> On 17/11/2023 11:42, Sibi Sankar wrote:
>>>> Replace SC8380xp with the updated part number (X1E80100).
>>>>
>>>
>>> You need to explain why. We don't update compatibles based on marketing
>>> wishes.
>>
>> What we imply is that X1E80100 is the part number you would get when you
>> read out from a Snapdragon X Elite device in the wild, when it is
>> available and we didn't have this information when we posted out v1.
>
> The commit msg must explain why.
(what Krzysztof meant is that your explanation is ok but it needs to be
part of the commit message and not just a reply here)
Moreover, it would also be good to say something like "this binding has
no users and has been erroneusly introduced very recently, so it was
decided that changing it is okay", as this is a rather special case.
Konrad
next prev parent reply other threads:[~2023-11-17 23:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 10:42 [PATCH 0/2] pmdomain: qcom: Update part number to X1E80100 Sibi Sankar
2023-11-17 10:42 ` [PATCH 1/2] dt-bindings: power: rpmpd: " Sibi Sankar
2023-11-17 11:05 ` Krzysztof Kozlowski
2023-11-17 11:46 ` Sibi Sankar
2023-11-17 12:39 ` Krzysztof Kozlowski
2023-11-17 23:40 ` Konrad Dybcio [this message]
2023-11-20 6:52 ` Sibi Sankar
2023-11-17 10:42 ` [PATCH 2/2] pmdomain: qcom: rpmhpd: " Sibi Sankar
2023-11-17 11:06 ` Krzysztof Kozlowski
2023-11-17 11:50 ` Sibi Sankar
2023-11-17 12:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=796fd7be-2008-460e-acf7-e335de780104@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox