[PATCH 0/2] pmdomain: qcom: Update part number to X1E80100

[PATCH 0/2] pmdomain: qcom: Update part number to X1E80100

[Sibi Sankar]

Our v1 post of the patchsets adding support for Snapdragon X Elite SoC had
the part number sc8380xp which is now updated to the new part number x1e80100
based on the new branding scheme and refers to the exact same SoC.

Dependencies: None
Release Link: https://www.qualcomm.com/news/releases/2023/10/qualcomm-unleashes-snapdragon-x-elite--the-ai-super-charged-plat

Sibi Sankar (2):
  dt-bindings: power: rpmpd: Update part number to X1E80100
  pmdomain: qcom: rpmhpd: Update part number to X1E80100

 .../devicetree/bindings/power/qcom,rpmpd.yaml        |  2 +-
 drivers/pmdomain/qcom/rpmhpd.c                       | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.17.1

[PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100

[Sibi Sankar]

Replace SC8380xp with the updated part number (X1E80100).

Fixes: c638b9516abd ("dt-bindings: power: rpmpd: Add SC8380XP support")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
 Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index da9c5846f4e1..2ff246cf8b81 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -39,7 +39,6 @@ properties:
           - qcom,sc7280-rpmhpd
           - qcom,sc8180x-rpmhpd
           - qcom,sc8280xp-rpmhpd
-          - qcom,sc8380xp-rpmhpd
           - qcom,sdm660-rpmpd
           - qcom,sdm670-rpmhpd
           - qcom,sdm845-rpmhpd
@@ -57,6 +56,7 @@ properties:
           - qcom,sm8450-rpmhpd
           - qcom,sm8550-rpmhpd
           - qcom,sm8650-rpmhpd
+          - qcom,x1e80100-rpmhpd
       - items:
           - enum:
               - qcom,msm8937-rpmpd
-- 
2.17.1

Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100

[Krzysztof Kozlowski]

On 17/11/2023 11:42, Sibi Sankar wrote:
> Replace SC8380xp with the updated part number (X1E80100).
> 

You need to explain why. We don't update compatibles based on marketing
wishes.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100

[Sibi Sankar]

Hey Krzysztof,

Thanks for taking time to review the series.

On 11/17/23 16:35, Krzysztof Kozlowski wrote:
> On 17/11/2023 11:42, Sibi Sankar wrote:
>> Replace SC8380xp with the updated part number (X1E80100).
>>
> 
> You need to explain why. We don't update compatibles based on marketing
> wishes.

What we imply is that X1E80100 is the part number you would get when you
read out from a Snapdragon X Elite device in the wild, when it is
available and we didn't have this information when we posted out v1.

-Sibi

> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100

[Krzysztof Kozlowski]

On 17/11/2023 12:46, Sibi Sankar wrote:
> Hey Krzysztof,
> 
> Thanks for taking time to review the series.
> 
> On 11/17/23 16:35, Krzysztof Kozlowski wrote:
>> On 17/11/2023 11:42, Sibi Sankar wrote:
>>> Replace SC8380xp with the updated part number (X1E80100).
>>>
>>
>> You need to explain why. We don't update compatibles based on marketing
>> wishes.
> 
> What we imply is that X1E80100 is the part number you would get when you
> read out from a Snapdragon X Elite device in the wild, when it is
> available and we didn't have this information when we posted out v1.

The commit msg must explain why.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100

[Konrad Dybcio]

On 17.11.2023 13:39, Krzysztof Kozlowski wrote:
> On 17/11/2023 12:46, Sibi Sankar wrote:
>> Hey Krzysztof,
>>
>> Thanks for taking time to review the series.
>>
>> On 11/17/23 16:35, Krzysztof Kozlowski wrote:
>>> On 17/11/2023 11:42, Sibi Sankar wrote:
>>>> Replace SC8380xp with the updated part number (X1E80100).
>>>>
>>>
>>> You need to explain why. We don't update compatibles based on marketing
>>> wishes.
>>
>> What we imply is that X1E80100 is the part number you would get when you
>> read out from a Snapdragon X Elite device in the wild, when it is
>> available and we didn't have this information when we posted out v1.
> 
> The commit msg must explain why.
(what Krzysztof meant is that your explanation is ok but it needs to be
part of the commit message and not just a reply here)

Moreover, it would also be good to say something like "this binding has
no users and has been erroneusly introduced very recently, so it was
decided that changing it is okay", as this is a rather special case.

Konrad

Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100

[Sibi Sankar]

On 11/18/23 05:10, Konrad Dybcio wrote:
> On 17.11.2023 13:39, Krzysztof Kozlowski wrote:
>> On 17/11/2023 12:46, Sibi Sankar wrote:
>>> Hey Krzysztof,
>>>
>>> Thanks for taking time to review the series.
>>>
>>> On 11/17/23 16:35, Krzysztof Kozlowski wrote:
>>>> On 17/11/2023 11:42, Sibi Sankar wrote:
>>>>> Replace SC8380xp with the updated part number (X1E80100).
>>>>>
>>>>
>>>> You need to explain why. We don't update compatibles based on marketing
>>>> wishes.
>>>
>>> What we imply is that X1E80100 is the part number you would get when you
>>> read out from a Snapdragon X Elite device in the wild, when it is
>>> available and we didn't have this information when we posted out v1.
>>
>> The commit msg must explain why.
> (what Krzysztof meant is that your explanation is ok but it needs to be
> part of the commit message and not just a reply here)
> 
> Moreover, it would also be good to say something like "this binding has
> no users and has been erroneusly introduced very recently, so it was
> decided that changing it is okay", as this is a rather special case.

Thanks, was going to do the same.

-Sibi

> 
> Konrad

[PATCH 2/2] pmdomain: qcom: rpmhpd: Update part number to X1E80100

[Sibi Sankar]

Replace SC8380xp with the updated part number (X1E80100).

Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
 drivers/pmdomain/qcom/rpmhpd.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
index f2e64324deb8..3078896b1300 100644
--- a/drivers/pmdomain/qcom/rpmhpd.c
+++ b/drivers/pmdomain/qcom/rpmhpd.c
@@ -598,8 +598,8 @@ static const struct rpmhpd_desc sc8280xp_desc = {
 	.num_pds = ARRAY_SIZE(sc8280xp_rpmhpds),
 };
 
-/* SC8380xp RPMH powerdomains */
-static struct rpmhpd *sc8380xp_rpmhpds[] = {
+/* X1E80100 RPMH powerdomains */
+static struct rpmhpd *x1e80100_rpmhpds[] = {
 	[RPMHPD_CX] = &cx,
 	[RPMHPD_CX_AO] = &cx_ao,
 	[RPMHPD_EBI] = &ebi,
@@ -615,9 +615,9 @@ static struct rpmhpd *sc8380xp_rpmhpds[] = {
 	[RPMHPD_GMXC] = &gmxc,
 };
 
-static const struct rpmhpd_desc sc8380xp_desc = {
-	.rpmhpds = sc8380xp_rpmhpds,
-	.num_pds = ARRAY_SIZE(sc8380xp_rpmhpds),
+static const struct rpmhpd_desc x1e80100_desc = {
+	.rpmhpds = x1e80100_rpmhpds,
+	.num_pds = ARRAY_SIZE(x1e80100_rpmhpds),
 };
 
 static const struct of_device_id rpmhpd_match_table[] = {
@@ -629,7 +629,6 @@ static const struct of_device_id rpmhpd_match_table[] = {
 	{ .compatible = "qcom,sc7280-rpmhpd", .data = &sc7280_desc },
 	{ .compatible = "qcom,sc8180x-rpmhpd", .data = &sc8180x_desc },
 	{ .compatible = "qcom,sc8280xp-rpmhpd", .data = &sc8280xp_desc },
-	{ .compatible = "qcom,sc8380xp-rpmhpd", .data = &sc8380xp_desc },
 	{ .compatible = "qcom,sdm670-rpmhpd", .data = &sdm670_desc },
 	{ .compatible = "qcom,sdm845-rpmhpd", .data = &sdm845_desc },
 	{ .compatible = "qcom,sdx55-rpmhpd", .data = &sdx55_desc},
@@ -643,6 +642,7 @@ static const struct of_device_id rpmhpd_match_table[] = {
 	{ .compatible = "qcom,sm8450-rpmhpd", .data = &sm8450_desc },
 	{ .compatible = "qcom,sm8550-rpmhpd", .data = &sm8550_desc },
 	{ .compatible = "qcom,sm8650-rpmhpd", .data = &sm8650_desc },
+	{ .compatible = "qcom,x1e80100-rpmhpd", .data = &x1e80100_desc },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, rpmhpd_match_table);
-- 
2.17.1

Re: [PATCH 2/2] pmdomain: qcom: rpmhpd: Update part number to X1E80100

[Krzysztof Kozlowski]

On 17/11/2023 11:42, Sibi Sankar wrote:
> Replace SC8380xp with the updated part number (X1E80100).
> 
> Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains")

No, there was no bug or at least you did not describe a bug. If it was a
bug, please define it in the commit msg.

Best regards,
Krzysztof

Re: [PATCH 2/2] pmdomain: qcom: rpmhpd: Update part number to X1E80100

[Sibi Sankar]

Hey Krzysztof,


On 11/17/23 16:36, Krzysztof Kozlowski wrote:
> On 17/11/2023 11:42, Sibi Sankar wrote:
>> Replace SC8380xp with the updated part number (X1E80100).
>>
>> Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains")
> 
> No, there was no bug or at least you did not describe a bug. If it was a
> bug, please define it in the commit msg.

It's technically replacing an obsolete part number with the correct
on, so I thought using the fixes tag makes sense. Let me add more
details on the next re-spin.

-Sibi

> 
> Best regards,
> Krzysztof
> 
> 

Re: [PATCH 2/2] pmdomain: qcom: rpmhpd: Update part number to X1E80100

[Krzysztof Kozlowski]

On 17/11/2023 12:50, Sibi Sankar wrote:
> Hey Krzysztof,
> 
> 
> On 11/17/23 16:36, Krzysztof Kozlowski wrote:
>> On 17/11/2023 11:42, Sibi Sankar wrote:
>>> Replace SC8380xp with the updated part number (X1E80100).
>>>
>>> Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains")
>>
>> No, there was no bug or at least you did not describe a bug. If it was a
>> bug, please define it in the commit msg.
> 
> It's technically replacing an obsolete part number with the correct
> on, so I thought using the fixes tag makes sense. Let me add more
> details on the next re-spin.

You are not replacing any obsolete device. It's purely naming style, so
no, that's not a valid reason for a fix. Drop fixes tag from both patches.

Best regards,
Krzysztof