From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v2 4/4] thermal: intel: int340x: Improve int340x_thermal_set_trip_temp()
Date: Tue, 31 Jan 2023 16:39:45 +0100 [thread overview]
Message-ID: <cb653a1e-1fbb-657f-0f61-8c27dde15655@linaro.org> (raw)
In-Reply-To: <3719164.kQq0lBPeGt@kreacher>
On 30/01/2023 19:47, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Instead of using snprintf() to populate the ACPI object name in
> int340x_thermal_set_trip_temp(), use an appropriate initializer
> and make the function fail if its trip argument is greater than 9,
> because ACPI object names can only be 4 characters long and it does
> not make sense to even try to evaluate objects with longer names (that
> argument is guaranteed to be non-negative, because it comes from the
> thermal code that will not pass negative trip numbers to zone
> callbacks).
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2023-01-31 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 18:37 [PATCH v2 0/4] thermal: intel: int340x: Assorted cleanups Rafael J. Wysocki
2023-01-30 18:42 ` [PATCH v2 1/4] thermal: intel: int340x: Assorted minor cleanups Rafael J. Wysocki
2023-01-31 15:36 ` Daniel Lezcano
2023-01-30 18:43 ` [PATCH v2 2/4] thermal: intel: int340x: Rename variable in int340x_thermal_zone_add() Rafael J. Wysocki
2023-01-30 18:45 ` [PATCH v2 3/4] thermal: intel: int340x: Drop pointless cast to unsigned long Rafael J. Wysocki
2023-01-31 15:38 ` Daniel Lezcano
2023-01-30 18:47 ` [PATCH v2 4/4] thermal: intel: int340x: Improve int340x_thermal_set_trip_temp() Rafael J. Wysocki
2023-01-31 15:39 ` Daniel Lezcano [this message]
2023-02-01 9:09 ` [PATCH v2 0/4] thermal: intel: int340x: Assorted cleanups Zhang, Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb653a1e-1fbb-657f-0f61-8c27dde15655@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox