* [PATCH v2] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust_perf()
@ 2024-02-08 10:00 Tor Vic
2024-02-09 15:42 ` [PATCH v3] " Tor Vic
0 siblings, 1 reply; 4+ messages in thread
From: Tor Vic @ 2024-02-08 10:00 UTC (permalink / raw)
To: Perry Yuan, Huang Rui, Rafael J . Wysocki, Mario Limonciello,
Shenoy, Gautham Ranjal
Cc: Linux Kernel Mailing List, linux-pm@vger.kernel.org,
Oleksandr Natalenko
In the function amd_pstate_adjust_perf(), the 'min_perf' variable is set
to 'highest_perf' instead of 'lowest_perf'.
Cc: stable@vger.kernel.org # 6.1+
Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for
AMD P-State")
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>
Signed-off-by: Tor Vic <torvic9@mailbox.org>
---
v1->v2: Add Perry's 'Reviewed-by' and 'Cc: stable' tag
---
drivers/cpufreq/amd-pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 08e112444c27..aa5e57e27d2b 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
if (target_perf < capacity)
des_perf = DIV_ROUND_UP(cap_perf * target_perf, capacity);
- min_perf = READ_ONCE(cpudata->highest_perf);
+ min_perf = READ_ONCE(cpudata->lowest_perf);
if (_min_perf < capacity)
min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v3] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust_perf()
2024-02-08 10:00 [PATCH v2] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust_perf() Tor Vic
@ 2024-02-09 15:42 ` Tor Vic
2024-02-09 15:49 ` Mario Limonciello
0 siblings, 1 reply; 4+ messages in thread
From: Tor Vic @ 2024-02-09 15:42 UTC (permalink / raw)
To: Perry.Yuan, ray.huang, gautham.shenoy, mario.limonciello,
rafael.j.wysocki
Cc: linux-kernel, linux-pm, Oleksandr Natalenko
In the function amd_pstate_adjust_perf(), the 'min_perf' variable is set
to 'highest_perf' instead of 'lowest_perf'.
Cc: <stable@vger.kernel.org> # 6.1+
Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>
Signed-off-by: Tor Vic <torvic9@mailbox.org>
---
v2->v3: Resend with git, misconfigured mail client borked v2
v1->v2: Add Perry's 'Reviewed-by' and 'Cc: stable' tag
---
drivers/cpufreq/amd-pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 08e112444c27..aa5e57e27d2b 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
if (target_perf < capacity)
des_perf = DIV_ROUND_UP(cap_perf * target_perf, capacity);
- min_perf = READ_ONCE(cpudata->highest_perf);
+ min_perf = READ_ONCE(cpudata->lowest_perf);
if (_min_perf < capacity)
min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust_perf()
2024-02-09 15:42 ` [PATCH v3] " Tor Vic
@ 2024-02-09 15:49 ` Mario Limonciello
2024-02-12 15:41 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Mario Limonciello @ 2024-02-09 15:49 UTC (permalink / raw)
To: Tor Vic, Perry.Yuan, ray.huang, gautham.shenoy, rafael.j.wysocki
Cc: linux-kernel, linux-pm, Oleksandr Natalenko
On 2/9/2024 09:42, Tor Vic wrote:
> In the function amd_pstate_adjust_perf(), the 'min_perf' variable is set
> to 'highest_perf' instead of 'lowest_perf'.
>
> Cc: <stable@vger.kernel.org> # 6.1+
> Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")
> Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>
> Signed-off-by: Tor Vic <torvic9@mailbox.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v2->v3: Resend with git, misconfigured mail client borked v2
> v1->v2: Add Perry's 'Reviewed-by' and 'Cc: stable' tag
> ---
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 08e112444c27..aa5e57e27d2b 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
> if (target_perf < capacity)
> des_perf = DIV_ROUND_UP(cap_perf * target_perf, capacity);
>
> - min_perf = READ_ONCE(cpudata->highest_perf);
> + min_perf = READ_ONCE(cpudata->lowest_perf);
> if (_min_perf < capacity)
> min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust_perf()
2024-02-09 15:49 ` Mario Limonciello
@ 2024-02-12 15:41 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2024-02-12 15:41 UTC (permalink / raw)
To: Mario Limonciello, Tor Vic
Cc: Perry.Yuan, ray.huang, gautham.shenoy, rafael.j.wysocki,
linux-kernel, linux-pm, Oleksandr Natalenko
On Fri, Feb 9, 2024 at 4:50 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 2/9/2024 09:42, Tor Vic wrote:
> > In the function amd_pstate_adjust_perf(), the 'min_perf' variable is set
> > to 'highest_perf' instead of 'lowest_perf'.
> >
> > Cc: <stable@vger.kernel.org> # 6.1+
> > Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")
> > Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> > Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>
> > Signed-off-by: Tor Vic <torvic9@mailbox.org>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> > ---
> > v2->v3: Resend with git, misconfigured mail client borked v2
> > v1->v2: Add Perry's 'Reviewed-by' and 'Cc: stable' tag
> > ---
> > drivers/cpufreq/amd-pstate.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 08e112444c27..aa5e57e27d2b 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
> > if (target_perf < capacity)
> > des_perf = DIV_ROUND_UP(cap_perf * target_perf, capacity);
> >
> > - min_perf = READ_ONCE(cpudata->highest_perf);
> > + min_perf = READ_ONCE(cpudata->lowest_perf);
> > if (_min_perf < capacity)
> > min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity);
> >
Applied as 6.9 material, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-12 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-08 10:00 [PATCH v2] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust_perf() Tor Vic
2024-02-09 15:42 ` [PATCH v3] " Tor Vic
2024-02-09 15:49 ` Mario Limonciello
2024-02-12 15:41 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox