[PATCH 0/2] arm64: dts: qcom: sc8180x: Fix CPUfreq compatible

[PATCH 0/2] arm64: dts: qcom: sc8180x: Fix CPUfreq compatible

[Bjorn Andersson]

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
Bjorn Andersson (2):
      dt-bindings: cpufreq: cpufreq-qcom-hw: Add sc8180x compatible
      arm64: dts: qcom: sc8180x: Correct cpufreq compatible

 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
 arch/arm64/boot/dts/qcom/sc8180x.dtsi                          | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
---
base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
change-id: 20240525-sc8180x-cpufreq-compatible-633c45b93886

Best regards,
-- 
Bjorn Andersson <quic_bjorande@quicinc.com>

[PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add sc8180x compatible

[Bjorn Andersson]

From: Bjorn Andersson <quic_bjorande@quicinc.com>

The SC8180X platform has a EPSS block, add a compatible for the SC8180X
platform.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
index 1e9797f96410..24c02ee33266 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
@@ -36,6 +36,7 @@ properties:
               - qcom,qdu1000-cpufreq-epss
               - qcom,sa8775p-cpufreq-epss
               - qcom,sc7280-cpufreq-epss
+              - qcom,sc8180x-cpufreq-epss
               - qcom,sc8280xp-cpufreq-epss
               - qcom,sdx75-cpufreq-epss
               - qcom,sm4450-cpufreq-epss

-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add sc8180x compatible

[Krzysztof Kozlowski]

On 25/05/2024 19:48, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> The SC8180X platform has a EPSS block, add a compatible for the SC8180X
> platform.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>  Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> index 1e9797f96410..24c02ee33266 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> @@ -36,6 +36,7 @@ properties:
>                - qcom,qdu1000-cpufreq-epss
>                - qcom,sa8775p-cpufreq-epss
>                - qcom,sc7280-cpufreq-epss
> +              - qcom,sc8180x-cpufreq-epss

I think you forgot to update the allOf:if:then: entry.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add sc8180x compatible

[Bjorn Andersson]

On Sun, May 26, 2024 at 08:23:24PM GMT, Krzysztof Kozlowski wrote:
> On 25/05/2024 19:48, Bjorn Andersson wrote:
> > From: Bjorn Andersson <quic_bjorande@quicinc.com>
> > 
> > The SC8180X platform has a EPSS block, add a compatible for the SC8180X
> > platform.
> > 
> > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> > ---
> >  Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> > index 1e9797f96410..24c02ee33266 100644
> > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> > @@ -36,6 +36,7 @@ properties:
> >                - qcom,qdu1000-cpufreq-epss
> >                - qcom,sa8775p-cpufreq-epss
> >                - qcom,sc7280-cpufreq-epss
> > +              - qcom,sc8180x-cpufreq-epss
> 
> I think you forgot to update the allOf:if:then: entry.
> 

Indeed, failed to spot that.

Thanks,
Bjorn

[PATCH 2/2] arm64: dts: qcom: sc8180x: Correct cpufreq compatible

[Bjorn Andersson]

From: Bjorn Andersson <quic_bjorande@quicinc.com>

The Qualcomm EPSS CPUfreq binding requires a platform-specific
compatible, add this.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index 067712310560..1f103cb54f99 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -3733,7 +3733,7 @@ lmh@18358800 {
 		};
 
 		cpufreq_hw: cpufreq@18323000 {
-			compatible = "qcom,cpufreq-hw";
+			compatible = "qcom,sc8180x-cpufreq-epss", "qcom,cpufreq-epss";
 			reg = <0 0x18323000 0 0x1400>, <0 0x18325800 0 0x1400>;
 			reg-names = "freq-domain0", "freq-domain1";
 

-- 
2.43.0

Re: [PATCH 2/2] arm64: dts: qcom: sc8180x: Correct cpufreq compatible

[Dmitry Baryshkov]

On Sat, May 25, 2024 at 10:48:51AM -0700, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> The Qualcomm EPSS CPUfreq binding requires a platform-specific
> compatible, add this.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

[PATCH 0/2] Fix SC8180X cpufreq dt-bindings error

[Konrad Dybcio]

Add the bindings and dt bits to fix:

cpufreq@18323000: compatible: 'oneOf' conditional failed, one must be fixed:
        ['qcom,cpufreq-hw'] is too short

No functional changes.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Konrad Dybcio (2):
      dt-bindings: cpufreq: cpufreq-qcom-hw: Add SC8180X compatible
      arm64: dts: qcom: sc8180x: Add a SoC-specific compatible to cpufreq-hw

 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 2 ++
 arch/arm64/boot/dts/qcom/sc8180x.dtsi                          | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
---
base-commit: 744cf71b8bdfcdd77aaf58395e068b7457634b2c
change-id: 20241116-topic-sc8180x_cpufreq_bindings-86f5b671602a

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

[PATCH 1/2] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SC8180X compatible

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Add a SoC-specific compatible for SC8180X. It has 2 domains and uses
the older, non-EPSS hardware.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
index 729f68c1f81d32e54e170879c4f7dd91c0d7c80a..e937eb7355e7fb74c0aeafb4cb9f5ed80d96e6c3 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
@@ -23,6 +23,7 @@ properties:
           - enum:
               - qcom,qcm2290-cpufreq-hw
               - qcom,sc7180-cpufreq-hw
+              - qcom,sc8180x-cpufreq-hw
               - qcom,sdm670-cpufreq-hw
               - qcom,sdm845-cpufreq-hw
               - qcom,sm6115-cpufreq-hw
@@ -135,6 +136,7 @@ allOf:
               - qcom,qdu1000-cpufreq-epss
               - qcom,sa8255p-cpufreq-epss
               - qcom,sc7180-cpufreq-hw
+              - qcom,sc8180x-cpufreq-hw
               - qcom,sc8280xp-cpufreq-epss
               - qcom,sdm670-cpufreq-hw
               - qcom,sdm845-cpufreq-hw

-- 
2.47.0