From: Shuah Khan <skhan@linuxfoundation.org>
To: Thorsten Leemhuis <linux@leemhuis.info>
Cc: linux-pm list <linux-pm@vger.kernel.org>,
Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>,
Justin Forbes <jforbes@redhat.com>,
Francesco Poli <invernomuto@paranoici.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] cpupower: split unitdir from libdir in Makefile
Date: Tue, 10 Jun 2025 09:13:00 -0600 [thread overview]
Message-ID: <e08b042c-0786-43d7-9b2a-21197cbb1458@linuxfoundation.org> (raw)
In-Reply-To: <b9533ccd-b38d-437e-8315-3ca4672d1b69@leemhuis.info>
On 6/7/25 01:50, Thorsten Leemhuis wrote:
> On 23.05.25 19:06, Shuah Khan wrote:
>> On 5/22/25 16:21, Francesco Poli wrote:
>>> On Thu, 22 May 2025 13:43:49 +0200 Thorsten Leemhuis wrote:
>>>
>>>> On 21.05.25 23:14, Francesco Poli (wintermute) wrote:
>>>>> Improve the installation procedure for the systemd service unit
>>>>> 'cpupower.service', to be more flexible. Some distros install libraries
>>>>> to /usr/lib64/, but systemd service units have to be installed to
>>>>> /usr/lib/systemd/system: as a consequence, the installation procedure
>>>>> should not assume that systemd service units can be installed to
>>>>> ${libdir}/systemd/system ...
>>>>> Define a dedicated variable ("unitdir") in the Makefile.
>>>> Many thx for doing this!
>>> You're welcome! :-)
>>
>> Thank you both. Applied to m,y cpupower branch. Will include it
>> in my next pr to PM maintainer.
>
> Thx. Sorry for pestering, but will you send that PR any time soon? The
> current state of things in mainline creates small problems downstream;
> not a big deal, but would be nice to get this resolved properly rather
> sooner than later my mainlining this change.
>
> Ciao, Thorsten
I am planning to send it today. I ran into merge issues when I tried to
send it on Friday.
thanks,
-- Shuah
prev parent reply other threads:[~2025-06-10 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 21:14 [PATCH] cpupower: split unitdir from libdir in Makefile Francesco Poli (wintermute)
2025-05-22 11:43 ` Thorsten Leemhuis
2025-05-22 22:21 ` Francesco Poli
2025-05-23 17:06 ` Shuah Khan
2025-06-07 7:50 ` Thorsten Leemhuis
2025-06-10 15:13 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e08b042c-0786-43d7-9b2a-21197cbb1458@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=invernomuto@paranoici.org \
--cc=jforbes@redhat.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox