* [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max frequency units
@ 2024-05-27 5:11 Dhananjay Ugwekar
2024-05-27 14:40 ` Mario Limonciello
0 siblings, 1 reply; 5+ messages in thread
From: Dhananjay Ugwekar @ 2024-05-27 5:11 UTC (permalink / raw)
To: rafael, ray.huang, viresh.kumar, Mario.Limonciello,
gautham.shenoy
Cc: ananth.narayan, linux-pm, linux-kernel, Perry.Yuan,
Dhananjay Ugwekar
The nominal frequency in cpudata is maintained in MHz whereas all other
frequencies are in KHz. This means we have to convert nominal frequency
value to KHz before we do any interaction with other frequency values.
In amd_pstate_set_boost(), this conversion from MHz to KHz is missed,
fix that.
Tested on a AMD Zen4 EPYC server
Before:
$ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
2151
$ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
400000
$ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
2151
409422
After:
$ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
2151000
$ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
400000
$ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
2151000
1799527
Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
---
drivers/cpufreq/amd-pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 1b7e82a0ad2e..cde3b91b4422 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -669,7 +669,7 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
if (state)
policy->cpuinfo.max_freq = cpudata->max_freq;
else
- policy->cpuinfo.max_freq = cpudata->nominal_freq;
+ policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000;
policy->max = policy->cpuinfo.max_freq;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max frequency units
2024-05-27 5:11 [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max frequency units Dhananjay Ugwekar
@ 2024-05-27 14:40 ` Mario Limonciello
2024-05-27 15:45 ` Gautham R. Shenoy
2024-05-28 20:05 ` Rafael J. Wysocki
0 siblings, 2 replies; 5+ messages in thread
From: Mario Limonciello @ 2024-05-27 14:40 UTC (permalink / raw)
To: Dhananjay Ugwekar, rafael, ray.huang, viresh.kumar,
gautham.shenoy
Cc: ananth.narayan, linux-pm, linux-kernel, Perry.Yuan
On 5/27/2024 00:11, Dhananjay Ugwekar wrote:
> The nominal frequency in cpudata is maintained in MHz whereas all other
> frequencies are in KHz. This means we have to convert nominal frequency
> value to KHz before we do any interaction with other frequency values.
>
> In amd_pstate_set_boost(), this conversion from MHz to KHz is missed,
> fix that.
>
> Tested on a AMD Zen4 EPYC server
>
> Before:
> $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> 2151
> $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> 400000
> $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> 2151
> 409422
>
> After:
> $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> 2151000
> $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> 400000
> $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> 2151000
> 1799527
>
Cc: stable@vger.kernel.org
> Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
> Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Acked-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 1b7e82a0ad2e..cde3b91b4422 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -669,7 +669,7 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
> if (state)
> policy->cpuinfo.max_freq = cpudata->max_freq;
> else
> - policy->cpuinfo.max_freq = cpudata->nominal_freq;
> + policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000;
>
> policy->max = policy->cpuinfo.max_freq;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max frequency units
2024-05-27 14:40 ` Mario Limonciello
@ 2024-05-27 15:45 ` Gautham R. Shenoy
2024-05-28 17:25 ` Peter Jung
2024-05-28 20:05 ` Rafael J. Wysocki
1 sibling, 1 reply; 5+ messages in thread
From: Gautham R. Shenoy @ 2024-05-27 15:45 UTC (permalink / raw)
To: Mario Limonciello
Cc: Dhananjay Ugwekar, rafael, ray.huang, viresh.kumar,
ananth.narayan, linux-pm, linux-kernel, Perry.Yuan
On Mon, May 27, 2024 at 09:40:21AM -0500, Mario Limonciello wrote:
> On 5/27/2024 00:11, Dhananjay Ugwekar wrote:
> > The nominal frequency in cpudata is maintained in MHz whereas all other
> > frequencies are in KHz. This means we have to convert nominal frequency
> > value to KHz before we do any interaction with other frequency values.
> >
> > In amd_pstate_set_boost(), this conversion from MHz to KHz is missed,
> > fix that.
> >
> > Tested on a AMD Zen4 EPYC server
> >
> > Before:
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> > 2151
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> > 400000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> > 2151
> > 409422
> >
> > After:
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> > 2151000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> > 400000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> > 2151000
> > 1799527
> >
>
> Cc: stable@vger.kernel.org
>
> > Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
> > Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
>
> Acked-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
>
> > ---
> > drivers/cpufreq/amd-pstate.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 1b7e82a0ad2e..cde3b91b4422 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -669,7 +669,7 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
> > if (state)
> > policy->cpuinfo.max_freq = cpudata->max_freq;
> > else
> > - policy->cpuinfo.max_freq = cpudata->nominal_freq;
> > + policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000;
> > policy->max = policy->cpuinfo.max_freq;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max frequency units
2024-05-27 15:45 ` Gautham R. Shenoy
@ 2024-05-28 17:25 ` Peter Jung
0 siblings, 0 replies; 5+ messages in thread
From: Peter Jung @ 2024-05-28 17:25 UTC (permalink / raw)
To: Gautham R. Shenoy, Mario Limonciello
Cc: Dhananjay Ugwekar, rafael, ray.huang, viresh.kumar,
ananth.narayan, linux-pm, linux-kernel, Perry.Yuan
> > > Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD
P-State driver to support future processors")
> > > Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> >
> > Acked-by: Mario Limonciello <mario.limonciello@amd.com>
>
> Acked-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Tested-by: Peter Jung <ptr1337@cachyos.org>
Fixes also an introduced regression in amd-pstate=passive reporting
wrong frequency values.
Also, see[1]
[1]https://github.com/CachyOS/linux-cachyos/issues/253#issuecomment-2135659124
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max frequency units
2024-05-27 14:40 ` Mario Limonciello
2024-05-27 15:45 ` Gautham R. Shenoy
@ 2024-05-28 20:05 ` Rafael J. Wysocki
1 sibling, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2024-05-28 20:05 UTC (permalink / raw)
To: Mario Limonciello, Dhananjay Ugwekar
Cc: rafael, ray.huang, viresh.kumar, gautham.shenoy, ananth.narayan,
linux-pm, linux-kernel, Perry.Yuan
On Mon, May 27, 2024 at 4:40 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 5/27/2024 00:11, Dhananjay Ugwekar wrote:
> > The nominal frequency in cpudata is maintained in MHz whereas all other
> > frequencies are in KHz. This means we have to convert nominal frequency
> > value to KHz before we do any interaction with other frequency values.
> >
> > In amd_pstate_set_boost(), this conversion from MHz to KHz is missed,
> > fix that.
> >
> > Tested on a AMD Zen4 EPYC server
> >
> > Before:
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> > 2151
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> > 400000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> > 2151
> > 409422
> >
> > After:
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> > 2151000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> > 400000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> > 2151000
> > 1799527
> >
>
> Cc: stable@vger.kernel.org
>
> > Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
> > Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
>
> Acked-by: Mario Limonciello <mario.limonciello@amd.com>
Applied as 6.10-rc material, thanks!
> > ---
> > drivers/cpufreq/amd-pstate.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 1b7e82a0ad2e..cde3b91b4422 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -669,7 +669,7 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
> > if (state)
> > policy->cpuinfo.max_freq = cpudata->max_freq;
> > else
> > - policy->cpuinfo.max_freq = cpudata->nominal_freq;
> > + policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000;
> >
> > policy->max = policy->cpuinfo.max_freq;
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-28 20:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 5:11 [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max frequency units Dhananjay Ugwekar
2024-05-27 14:40 ` Mario Limonciello
2024-05-27 15:45 ` Gautham R. Shenoy
2024-05-28 17:25 ` Peter Jung
2024-05-28 20:05 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox