Linux Power Management development
 help / color / mirror / Atom feed
* [GIT PULL] cpupower update for Linux 6.17-rc1
@ 2025-07-08 19:40 Shuah Khan
  2025-07-09 13:13 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan @ 2025-07-08 19:40 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: shuah, Shuah Khan, Thomas Renninger, Thomas Renninger,
	John B. Wyatt IV, John Kacur, linux-pm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

Hi Rafael,

Please pull the following cpupower update for Linux 6.17-rc1.

Fixes
  - snapshot-order of tsc ,mperf, clock in mperf_stop()
  - printing of CORE, CPU fields in cpupower-monitor

Improves Python binding's Makefile

diff is attached.

thanks,
-- Shuah

----------------------------------------------------------------
The following changes since commit e044b8a9545cd8265c7110c179aeec2624c16455:

   cpupower: split unitdir from libdir in Makefile (2025-06-09 10:17:46 -0600)

are available in the Git repository at:

   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux tags/linux-cpupower-6.17-rc1-fixed

for you to fetch changes up to b74710eaff314d6afe4fb0bbe9bc7657bf226fd4:

   cpupower: Improve Python binding's Makefile (2025-07-01 10:58:00 -0600)

----------------------------------------------------------------
linux-cpupower-6.17-rc1-fixed

Fixes
  - snapshot-order of tsc,mperf, clock in mperf_stop()
  - printing of CORE, CPU fields in cpupower-monitor

Improves Python binding's Makefile

----------------------------------------------------------------
Gautham R. Shenoy (2):
       pm: cpupower: Fix the snapshot-order of tsc,mperf, clock in mperf_stop()
       pm: cpupower: Fix printing of CORE, CPU fields in cpupower-monitor

John B. Wyatt IV (1):
       cpupower: Improve Python binding's Makefile

  tools/power/cpupower/bindings/python/Makefile              | 12 +++++++-----
  tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c |  4 ----
  tools/power/cpupower/utils/idle_monitor/mperf_monitor.c    |  4 ++--
  3 files changed, 9 insertions(+), 11 deletions(-)
----------------------------------------------------------------

[-- Attachment #2: linux-cpupower-6.17-rc1-fixed.diff --]
[-- Type: text/x-patch, Size: 2927 bytes --]

diff --git a/tools/power/cpupower/bindings/python/Makefile b/tools/power/cpupower/bindings/python/Makefile
index 81db39a03efb..4527cd732b42 100644
--- a/tools/power/cpupower/bindings/python/Makefile
+++ b/tools/power/cpupower/bindings/python/Makefile
@@ -4,20 +4,22 @@
 # This Makefile expects you have already run `make install-lib` in the lib
 # directory for the bindings to be created.
 
-CC := gcc
+CC ?= gcc
+# CFLAGS ?=
+LDFLAGS ?= -lcpupower
 HAVE_SWIG := $(shell if which swig >/dev/null 2>&1; then echo 1; else echo 0; fi)
 HAVE_PYCONFIG := $(shell if which python-config >/dev/null 2>&1; then echo 1; else echo 0; fi)
 
-PY_INCLUDE = $(firstword $(shell python-config --includes))
-INSTALL_DIR = $(shell python3 -c "import site; print(site.getsitepackages()[0])")
+PY_INCLUDE ?= $(firstword $(shell python-config --includes))
+INSTALL_DIR ?= $(shell python3 -c "import site; print(site.getsitepackages()[0])")
 
 all: _raw_pylibcpupower.so
 
 _raw_pylibcpupower.so: raw_pylibcpupower_wrap.o
-	$(CC) -shared -lcpupower raw_pylibcpupower_wrap.o -o _raw_pylibcpupower.so
+	$(CC) -shared $(LDFLAGS) raw_pylibcpupower_wrap.o -o _raw_pylibcpupower.so
 
 raw_pylibcpupower_wrap.o: raw_pylibcpupower_wrap.c
-	$(CC) -fPIC -c raw_pylibcpupower_wrap.c $(PY_INCLUDE)
+	$(CC) $(CFLAGS) $(PY_INCLUDE) -fPIC -c raw_pylibcpupower_wrap.c
 
 raw_pylibcpupower_wrap.c: raw_pylibcpupower.swg
 ifeq ($(HAVE_SWIG),0)
diff --git a/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c b/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
index ad493157f826..e8b3841d5c0f 100644
--- a/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
+++ b/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
@@ -121,10 +121,8 @@ void print_header(int topology_depth)
 	switch (topology_depth) {
 	case TOPOLOGY_DEPTH_PKG:
 		printf(" PKG|");
-		break;
 	case TOPOLOGY_DEPTH_CORE:
 		printf("CORE|");
-		break;
 	case	TOPOLOGY_DEPTH_CPU:
 		printf(" CPU|");
 		break;
@@ -167,10 +165,8 @@ void print_results(int topology_depth, int cpu)
 	switch (topology_depth) {
 	case TOPOLOGY_DEPTH_PKG:
 		printf("%4d|", cpu_top.core_info[cpu].pkg);
-		break;
 	case TOPOLOGY_DEPTH_CORE:
 		printf("%4d|", cpu_top.core_info[cpu].core);
-		break;
 	case TOPOLOGY_DEPTH_CPU:
 		printf("%4d|", cpu_top.core_info[cpu].cpu);
 		break;
diff --git a/tools/power/cpupower/utils/idle_monitor/mperf_monitor.c b/tools/power/cpupower/utils/idle_monitor/mperf_monitor.c
index 73b6b10cbdd2..5ae02c3d5b64 100644
--- a/tools/power/cpupower/utils/idle_monitor/mperf_monitor.c
+++ b/tools/power/cpupower/utils/idle_monitor/mperf_monitor.c
@@ -240,9 +240,9 @@ static int mperf_stop(void)
 	int cpu;
 
 	for (cpu = 0; cpu < cpu_count; cpu++) {
-		mperf_measure_stats(cpu);
-		mperf_get_tsc(&tsc_at_measure_end[cpu]);
 		clock_gettime(CLOCK_REALTIME, &time_end[cpu]);
+		mperf_get_tsc(&tsc_at_measure_end[cpu]);
+		mperf_measure_stats(cpu);
 	}
 
 	return 0;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] cpupower update for Linux 6.17-rc1
  2025-07-08 19:40 [GIT PULL] cpupower update for Linux 6.17-rc1 Shuah Khan
@ 2025-07-09 13:13 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2025-07-09 13:13 UTC (permalink / raw)
  To: Shuah Khan
  Cc: Rafael J. Wysocki, shuah, Thomas Renninger, Thomas Renninger,
	John B. Wyatt IV, John Kacur, linux-pm, linux-kernel

Hi Shuah,

On Tue, Jul 8, 2025 at 9:40 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> Hi Rafael,
>
> Please pull the following cpupower update for Linux 6.17-rc1.
>
> Fixes
>   - snapshot-order of tsc ,mperf, clock in mperf_stop()
>   - printing of CORE, CPU fields in cpupower-monitor
>
> Improves Python binding's Makefile
>
> diff is attached.
>
> thanks,
> -- Shuah
>
> ----------------------------------------------------------------
> The following changes since commit e044b8a9545cd8265c7110c179aeec2624c16455:
>
>    cpupower: split unitdir from libdir in Makefile (2025-06-09 10:17:46 -0600)
>
> are available in the Git repository at:
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux tags/linux-cpupower-6.17-rc1-fixed
>
> for you to fetch changes up to b74710eaff314d6afe4fb0bbe9bc7657bf226fd4:
>
>    cpupower: Improve Python binding's Makefile (2025-07-01 10:58:00 -0600)
>
> ----------------------------------------------------------------
> linux-cpupower-6.17-rc1-fixed
>
> Fixes
>   - snapshot-order of tsc,mperf, clock in mperf_stop()
>   - printing of CORE, CPU fields in cpupower-monitor
>
> Improves Python binding's Makefile
>
> ----------------------------------------------------------------
> Gautham R. Shenoy (2):
>        pm: cpupower: Fix the snapshot-order of tsc,mperf, clock in mperf_stop()
>        pm: cpupower: Fix printing of CORE, CPU fields in cpupower-monitor
>
> John B. Wyatt IV (1):
>        cpupower: Improve Python binding's Makefile
>
>   tools/power/cpupower/bindings/python/Makefile              | 12 +++++++-----
>   tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c |  4 ----
>   tools/power/cpupower/utils/idle_monitor/mperf_monitor.c    |  4 ++--
>   3 files changed, 9 insertions(+), 11 deletions(-)
> ----------------------------------------------------------------

Pulled and added to linux-pm.git/linux-next, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-09 13:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-08 19:40 [GIT PULL] cpupower update for Linux 6.17-rc1 Shuah Khan
2025-07-09 13:13 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox