Linux Power Management development
 help / color / mirror / Atom feed
From: Christian Loehle <christian.loehle@arm.com>
To: Anjali K <anjalik@linux.ibm.com>,
	Qais Yousef <qyousef@layalina.io>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Juri Lelli <juri.lelli@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Hongyan Xia <hongyan.xia2@arm.com>,
	John Stultz <jstultz@google.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] sched: Consolidate cpufreq updates
Date: Tue, 8 Oct 2024 10:56:02 +0100	[thread overview]
Message-ID: <fa2f15b1-1602-4fd0-80ff-9d33303b7b5a@arm.com> (raw)
In-Reply-To: <ae65e4aa-3407-4fb0-b1f1-eb7c2626f768@linux.ibm.com>

On 10/7/24 18:20, Anjali K wrote:
> Hi, I tested this patch to see if it causes any regressions on bare-metal power9 systems with microbenchmarks.
> The test system is a 2 NUMA node 128 cpu powernv power9 system. The conservative governor is enabled.
> I took the baseline as the 6.10.0-rc1 tip sched/core kernel.
> No regressions were found.
> 
> +------------------------------------------------------+--------------------+----------+
> |                     Benchmark                        |      Baseline      | Baseline |
> |                                                      |  (6.10.0-rc1 tip   | + patch  |
> |                                                      |  sched/core)       |          |
> +------------------------------------------------------+--------------------+----------+
> |Hackbench run duration (sec)                          |         1          |   1.01   |
> |Lmbench simple fstat (usec)                           |         1          |   0.99   |
> |Lmbench simple open/close (usec)                      |         1          |   1.02   |
> |Lmbench simple read (usec)                            |         1          |   1      |
> |Lmbench simple stat (usec)                            |         1          |   1.01   |
> |Lmbench simple syscall (usec)                         |         1          |   1.01   |
> |Lmbench simple write (usec)                           |         1          |   1      |
> |stressng (bogo ops)                                   |         1          |   0.94   |
> |Unixbench execl throughput (lps)                      |         1          |   0.97   |
> |Unixbench Pipebased Context Switching throughput (lps)|         1          |   0.94   |
> |Unixbench Process Creation (lps)                      |         1          |   1      |
> |Unixbench Shell Scripts (1 concurrent) (lpm)          |         1          |   1      |
> |Unixbench Shell Scripts (8 concurrent) (lpm)          |         1          |   1.01   |
> +------------------------------------------------------+--------------------+----------+
> 
> Thank you,
> Anjali K
> 

The default CPUFREQ_DBS_MIN_SAMPLING_INTERVAL is still to have 2 ticks between
cpufreq updates on conservative/ondemand.
What is your sampling_rate setting? What's your HZ?
Interestingly the context switch heavy benchmarks still show -6% don't they?
Do you mind trying schedutil with a reasonable rate_limit_us, too?

Regards,
Christian


  reply	other threads:[~2024-10-08  9:56 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-28 18:45 [PATCH v7] sched: Consolidate cpufreq updates Qais Yousef
2024-07-29 16:01 ` Metin Kaya
2024-08-01 12:22   ` Qais Yousef
2024-08-05 15:35 ` Christian Loehle
2024-08-09  1:13   ` Qais Yousef
2024-08-13  8:25   ` Vincent Guittot
2024-08-13  8:27     ` Vincent Guittot
2024-08-13 16:26       ` Christian Loehle
2024-08-13 16:43         ` Vincent Guittot
2024-08-13 16:56           ` Christian Loehle
2024-09-01 17:51       ` Qais Yousef
2024-09-02 12:30         ` Vincent Guittot
2024-09-02 12:35           ` Christian Loehle
2024-09-02 12:43             ` Vincent Guittot
2024-09-02 12:58           ` Qais Yousef
2024-09-02 13:34             ` Qais Yousef
2024-09-02 13:40               ` Christian Loehle
2024-09-02 13:36             ` Vincent Guittot
2024-09-02 20:43               ` Qais Yousef
2024-09-03  6:54                 ` Vincent Guittot
2024-08-13 10:02 ` Vincent Guittot
2024-09-01 18:01   ` Qais Yousef
2024-09-03 12:48     ` Vincent Guittot
2024-09-11 20:34 ` Christian Loehle
2024-09-12 11:33   ` Rafael J. Wysocki
2025-02-09 22:34     ` Qais Yousef
2024-10-07 17:20 ` Anjali K
2024-10-08  9:56   ` Christian Loehle [this message]
2024-10-10 18:32     ` Christian Loehle
2024-10-18 18:32     ` Anjali K
2024-11-25  6:32       ` Anjali K
2025-02-09 22:33         ` Qais Yousef
2024-10-11  9:34 ` Christian Loehle
2025-02-09 22:41   ` Qais Yousef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa2f15b1-1602-4fd0-80ff-9d33303b7b5a@arm.com \
    --to=christian.loehle@arm.com \
    --cc=anjalik@linux.ibm.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=hongyan.xia2@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox