From: Paolo Abeni <pabeni@redhat.com>
To: Qingfang Deng <qingfang.deng@linux.dev>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Kees Cook <kees@kernel.org>,
Guillaume Nault <gnault@redhat.com>,
Eric Woudstra <ericwouds@gmail.com>, Felix Fietkau <nbd@nbd.name>,
Willem de Bruijn <willemb@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Richard Gobert <richardbgobert@gmail.com>,
Jiayuan Chen <jiayuan.chen@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-ppp@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH net-next v9 1/2] net: pppoe: implement GRO/GSO support
Date: Tue, 12 May 2026 15:58:28 +0200 [thread overview]
Message-ID: <a5b3ac22-1515-4642-ad55-1f8b564cc140@redhat.com> (raw)
In-Reply-To: <20260509030507.387050-1-qingfang.deng@linux.dev>
On 5/9/26 5:04 AM, Qingfang Deng wrote:
> +static struct sk_buff *pppoe_gso_segment(struct sk_buff *skb,
> + netdev_features_t features)
> +{
> + struct sk_buff *segs = ERR_PTR(-EINVAL);
> + struct packet_offload *ptype;
> + struct pppoe_hdr *phdr;
> + __be16 orig_type, type;
> + int len, nhoff;
> +
> + skb_reset_network_header(skb);
> + nhoff = skb_network_header(skb) - skb_mac_header(skb);
> +
> + if (unlikely(!pskb_may_pull(skb, PPPOE_SES_HLEN)))
> + goto out;
> +
> + phdr = (struct pppoe_hdr *)skb_network_header(skb);
> + type = pppoe_hdr_proto(phdr);
> + ptype = gro_find_complete_by_type(type);
> + if (!ptype)
> + goto out;
> +
> + orig_type = skb->protocol;
> + __skb_pull(skb, PPPOE_SES_HLEN);
> + features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
As sashiko points out here you need to use NETIF_F_GSO_SOFTWARE.
/P
next prev parent reply other threads:[~2026-05-12 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 3:04 [PATCH net-next v9 1/2] net: pppoe: implement GRO/GSO support Qingfang Deng
2026-05-09 3:04 ` [PATCH net-next v9 2/2] selftests: net: test PPPoE packets in gro.sh Qingfang Deng
2026-05-12 13:58 ` Paolo Abeni [this message]
2026-05-12 17:32 ` [PATCH net-next v9 1/2] net: pppoe: implement GRO/GSO support Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5b3ac22-1515-4642-ad55-1f8b564cc140@redhat.com \
--to=pabeni@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiayuan.chen@linux.dev \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=qingfang.deng@linux.dev \
--cc=richardbgobert@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox