[PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM backlight driver use the wrong PWM chip and fail the driver probing if multiple PWM chips exist. This defect could also cause the unintended PWM chip used and unaccessable by other drivers. The patch will check the error state first and allow a deferral PWM backlight probing if the intended PWM driver is not loaded at the probing moment.

[PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM backlight driver use the wrong PWM chip and fail the driver probing if multiple PWM chips exist. This defect could also cause the unintended PWM chip used and unaccessable by other drivers. The patch will check the error state first and allow a deferral PWM backlight probing if the intended PWM driver is not loaded at the probing moment.

[ryang]

Signed-off-by: ryang <ryang@hach.com>
---
 drivers/video/backlight/pwm_bl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index b85983e..e0014a5 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -273,6 +273,9 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 
 	pb->pwm = devm_pwm_get(&pdev->dev, NULL);
 	if (IS_ERR(pb->pwm)) {
+		ret = PTR_ERR(pb->pwm);
+		if (ret == -EPROBE_DEFER)
+			goto err_alloc;
 		dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
 
 		pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");
-- 
1.9.1

Re: [PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM backlight driver use the wrong PWM chip and fail the driver probing if multiple PWM chips exist. This defect could also cause the unintended PWM chip used and unaccessable by other drivers. The patch will check the error state first and allow a deferral PWM backlight probing if the intended PWM driver is not loaded at the probing moment.

[Lee Jones]

I'm guessing this is your first patch.

Please read: Documentation/SubmittingPatches

A few notes for you search for and read about in the above document.

 - Subject line formatting (short, succinct) 
 - Commit logs (present, descriptive [what changed and why], succinct)
 - Authorship (full/real names only)

> Signed-off-by: ryang <ryang@hach.com>
> ---
>  drivers/video/backlight/pwm_bl.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index b85983e..e0014a5 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -273,6 +273,9 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>  
>  	pb->pwm = devm_pwm_get(&pdev->dev, NULL);
>  	if (IS_ERR(pb->pwm)) {
> +		ret = PTR_ERR(pb->pwm);
> +		if (ret == -EPROBE_DEFER)
> +			goto err_alloc;
>  		dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
>  
>  		pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM backlight driver use the wrong PWM chip and fail the driver probing if multiple PWM chips exist. This defect could also cause the unintended PWM chip used and unaccessable by other drivers. The patch will check the error state first and allow a deferral PWM backlight probing if the intended PWM driver is not loaded at the probing moment.

[Lee Jones]

> I'm guessing this is your first patch.
> 
> Please read: Documentation/SubmittingPatches
> 
> A few notes for you search for and read about in the above document.
> 
>  - Subject line formatting (short, succinct) 
>  - Commit logs (present, descriptive [what changed and why], succinct)
>  - Authorship (full/real names only)

You also need to CC linux-kernel@vger.kernel.org on all patches.

> > Signed-off-by: ryang <ryang@hach.com>
> > ---
> >  drivers/video/backlight/pwm_bl.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index b85983e..e0014a5 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -273,6 +273,9 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >  
> >  	pb->pwm = devm_pwm_get(&pdev->dev, NULL);
> >  	if (IS_ERR(pb->pwm)) {
> > +		ret = PTR_ERR(pb->pwm);
> > +		if (ret == -EPROBE_DEFER)
> > +			goto err_alloc;
> >  		dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
> >  
> >  		pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM backlight driver use the wrong PWM chip and fail the driver probing if multiple PWM chips exist. This defect could also cause the unintended PWM chip used and unaccessable by other dri...

[Yang, Robert]

Hi Lee,
It is great to get your reply. No, this is  a second one, actually it is a resend. This time I just followed Thierry's instruction using the git patch and send-mail commands.

Robert


-----Original Message-----
From: Lee Jones [mailto:lee.jones@linaro.org]
Sent: Thursday, September 04, 2014 2:40 AM
To: ryang
Cc: thierry.reding@gmail.com; jg1.han@samsung.com; linux-pwm@vger.kernel.org; Yang, Robert; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM backlight driver use the wrong PWM chip and fail the driver probing if multiple PWM chips exist. This defect could also cause the unintended PWM chip used and unaccessable by other dri...

> I'm guessing this is your first patch.
>
> Please read: Documentation/SubmittingPatches
>
> A few notes for you search for and read about in the above document.
>
>  - Subject line formatting (short, succinct)
>  - Commit logs (present, descriptive [what changed and why], succinct)
>  - Authorship (full/real names only)

You also need to CC linux-kernel@vger.kernel.org on all patches.

> > Signed-off-by: ryang <ryang@hach.com>
> > ---
> >  drivers/video/backlight/pwm_bl.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c
> > b/drivers/video/backlight/pwm_bl.c
> > index b85983e..e0014a5 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -273,6 +273,9 @@ static int pwm_backlight_probe(struct
> > platform_device *pdev)
> >
> >     pb->pwm = devm_pwm_get(&pdev->dev, NULL);
> >     if (IS_ERR(pb->pwm)) {
> > +           ret = PTR_ERR(pb->pwm);
> > +           if (ret == -EPROBE_DEFER)
> > +                   goto err_alloc;
> >             dev_err(&pdev->dev, "unable to request PWM, trying legacy
> > API\n");
> >
> >             pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment.