From: Philipp Zabel <p.zabel@pengutronix.de>
To: YH Huang <yh.huang@mediatek.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
yingjoe.chen@mediatek.com,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] pwm-backlight: fix the panel power sequence
Date: Thu, 29 Oct 2015 16:40:59 +0100 [thread overview]
Message-ID: <1446133259.3274.52.camel@pengutronix.de> (raw)
In-Reply-To: <1445526750.27586.8.camel@mtksdaap41>
Hi YH,
Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang:
> In the case of the panel disabled by the bootloader,
> your patch still has the following code and always enables the backlight
> in the probe function.
> pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
> - GPIOD_OUT_HIGH);
You are right.
> What do you think if I remove these two lines in my patch?
> if (pb->enable_gpio)
> gpiod_direction_output(pb->enable_gpio, 0);
That won't work if the gpio is still configured as input. How about I
add the GPIOD_ASIS change to my patch you remove that and the above from
yours?
best regards
Philipp
next prev parent reply other threads:[~2015-10-29 15:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 9:17 [PATCH v2] pwm-backlight: fix the panel power sequence YH Huang
2015-10-16 9:36 ` Philipp Zabel
2015-10-22 15:12 ` YH Huang
2015-10-29 15:40 ` Philipp Zabel [this message]
2015-10-30 7:41 ` YH Huang
2015-10-30 10:34 ` Philipp Zabel
2015-11-03 8:11 ` YH Huang
2015-11-03 11:08 ` Philipp Zabel
2015-11-04 1:47 ` YH Huang
2015-11-05 9:40 ` Philipp Zabel
2015-11-06 8:31 ` YH Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446133259.3274.52.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=plagnioj@jcrosoft.com \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=yh.huang@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox