From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org,
"Guru Das Srinagesh" <gurus@codeaurora.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
linux-clk@vger.kernel.org,
"David Laight" <David.Laight@ACULAB.COM>
Subject: [PATCH v10 11/12] clk: pwm: Assign u64 divisor to unsigned int before use
Date: Thu, 19 Mar 2020 13:50:14 -0700 [thread overview]
Message-ID: <2009030fe415c02cc92f0189d3e79de34982536c.1584650604.git.gurus@codeaurora.org> (raw)
In-Reply-To: <cover.1584650604.git.gurus@codeaurora.org>
In-Reply-To: <cover.1584650604.git.gurus@codeaurora.org>
Since the PWM framework is switching struct pwm_args.period's datatype
to u64, prepare for this transition by assigning the 64-bit divisor to
an unsigned int variable to use as the divisor. This is being done
because the divisor is a 32-bit constant and the quotient will be zero
if the divisor exceeds 2^32.
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org
Cc: David Laight <David.Laight@ACULAB.COM>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
---
drivers/clk/clk-pwm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c
index 87fe0b0e..c0b5da3 100644
--- a/drivers/clk/clk-pwm.c
+++ b/drivers/clk/clk-pwm.c
@@ -72,6 +72,7 @@ static int clk_pwm_probe(struct platform_device *pdev)
struct pwm_device *pwm;
struct pwm_args pargs;
const char *clk_name;
+ unsigned int period;
int ret;
clk_pwm = devm_kzalloc(&pdev->dev, sizeof(*clk_pwm), GFP_KERNEL);
@@ -88,8 +89,9 @@ static int clk_pwm_probe(struct platform_device *pdev)
return -EINVAL;
}
+ period = pargs.period;
if (of_property_read_u32(node, "clock-frequency", &clk_pwm->fixed_rate))
- clk_pwm->fixed_rate = NSEC_PER_SEC / pargs.period;
+ clk_pwm->fixed_rate = NSEC_PER_SEC / period;
if (pargs.period != NSEC_PER_SEC / clk_pwm->fixed_rate &&
pargs.period != DIV_ROUND_UP(NSEC_PER_SEC, clk_pwm->fixed_rate)) {
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-03-19 20:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 20:50 [PATCH v10 00/12] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 01/12] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 02/12] hwmon: pwm-fan: " Guru Das Srinagesh
2020-03-19 21:12 ` Guenter Roeck
2020-03-20 1:13 ` Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 03/12] ir-rx51: " Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 04/12] pwm: clps711x: Cast period to u32 before use as divisor Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 05/12] pwm: pwm-imx-tpm: Use 64-bit division macro Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 06/12] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 07/12] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 08/12] pwm: stm32-lp: Use %llu format specifier for period Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 09/12] pwm: sun4i: Use 64-bit division function Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 10/12] backlight: pwm_bl: " Guru Das Srinagesh
2020-03-19 20:50 ` Guru Das Srinagesh [this message]
2020-03-19 20:50 ` [PATCH v10 12/12] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
2020-03-21 11:47 ` [PATCH v10 00/12] Convert PWM " Dan Carpenter
2020-03-30 19:15 ` Guru Das Srinagesh
2020-03-30 20:26 ` Daniel Thompson
2020-03-30 21:00 ` Guru Das Srinagesh
2020-03-31 13:48 ` Daniel Thompson
2020-03-31 19:59 ` Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2009030fe415c02cc92f0189d3e79de34982536c.1584650604.git.gurus@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=David.Laight@ACULAB.COM \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox