From: Thierry Reding <thierry.reding@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: laurent.pinchart+renesas@ideasonboard.com, axel.lin@ingics.com,
yongjun_wei@trendmicro.com.cn, linux-pwm@vger.kernel.org
Subject: Re: [PATCH -next] pwm: renesas-tpu: fix return value check in tpu_probe()
Date: Tue, 25 Jun 2013 12:21:56 +0200 [thread overview]
Message-ID: <20130625102155.GB21137@manwe> (raw)
In-Reply-To: <CAPgLHd8x180B9OxscFeiLrnYT4dUf66hZCxSJO_1E+uE5udx0A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
On Tue, Jun 25, 2013 at 10:09:57AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied with the change that Laurent squashed in. Thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-25 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 2:09 [PATCH -next] pwm: renesas-tpu: fix return value check in tpu_probe() Wei Yongjun
2013-06-25 2:59 ` Axel Lin
2013-06-25 8:59 ` Laurent Pinchart
2013-06-25 10:18 ` Thierry Reding
2013-06-25 10:21 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625102155.GB21137@manwe \
--to=thierry.reding@gmail.com \
--cc=axel.lin@ingics.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-pwm@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox