Linux PWM subsystem development
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
	axel.lin@ingics.com, yongjun_wei@trendmicro.com.cn,
	linux-pwm@vger.kernel.org
Subject: Re: [PATCH -next] pwm: renesas-tpu: fix return value check in tpu_probe()
Date: Tue, 25 Jun 2013 12:18:25 +0200	[thread overview]
Message-ID: <20130625101824.GA21137@manwe> (raw)
In-Reply-To: <19060081.EBSPSCq8RF@avalon>

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

On Tue, Jun 25, 2013 at 10:59:49AM +0200, Laurent Pinchart wrote:
> Hi Wei,
> 
> Thank you for the patch.
> 
> On Tuesday 25 June 2013 10:09:57 Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > 
> > In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> > and never returns NULL. The NULL test in the return value check should
> > be replaced with IS_ERR().
> > 
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> With the change noted below,
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Thierry, do you need a v2, or can you fix the patch while applying ?

No that's fine, I'll fix it up when applying. I should've noticed in the
first place anyway since I wrote devm_ioremap_resource() specifically so
that it never returns NULL and the error message wasn't required. =\

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-06-25 10:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25  2:09 [PATCH -next] pwm: renesas-tpu: fix return value check in tpu_probe() Wei Yongjun
2013-06-25  2:59 ` Axel Lin
2013-06-25  8:59 ` Laurent Pinchart
2013-06-25 10:18   ` Thierry Reding [this message]
2013-06-25 10:21 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130625101824.GA21137@manwe \
    --to=thierry.reding@gmail.com \
    --cc=axel.lin@ingics.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-pwm@vger.kernel.org \
    --cc=weiyj.lk@gmail.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox