* [PATCH] pwm: Delete an unnecessary check before the function call "of_node_put" [not found] ` <5317A59D.4@users.sourceforge.net> @ 2015-02-03 10:58 ` SF Markus Elfring 2015-02-03 11:57 ` Thierry Reding 0 siblings, 1 reply; 2+ messages in thread From: SF Markus Elfring @ 2015-02-03 10:58 UTC (permalink / raw) To: Thierry Reding, linux-pwm; +Cc: LKML, kernel-janitors, Julia Lawall From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 3 Feb 2015 11:54:28 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/pwm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 966497d..810aef3 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -192,7 +192,7 @@ static void of_pwmchip_add(struct pwm_chip *chip) static void of_pwmchip_remove(struct pwm_chip *chip) { - if (chip->dev && chip->dev->of_node) + if (chip->dev) of_node_put(chip->dev->of_node); } -- 2.2.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pwm: Delete an unnecessary check before the function call "of_node_put" 2015-02-03 10:58 ` [PATCH] pwm: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring @ 2015-02-03 11:57 ` Thierry Reding 0 siblings, 0 replies; 2+ messages in thread From: Thierry Reding @ 2015-02-03 11:57 UTC (permalink / raw) To: SF Markus Elfring; +Cc: linux-pwm, LKML, kernel-janitors, Julia Lawall [-- Attachment #1: Type: text/plain, Size: 965 bytes --] On Tue, Feb 03, 2015 at 11:58:29AM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 3 Feb 2015 11:54:28 +0100 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/pwm/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > index 966497d..810aef3 100644 > --- a/drivers/pwm/core.c > +++ b/drivers/pwm/core.c > @@ -192,7 +192,7 @@ static void of_pwmchip_add(struct pwm_chip *chip) > > static void of_pwmchip_remove(struct pwm_chip *chip) > { > - if (chip->dev && chip->dev->of_node) > + if (chip->dev) > of_node_put(chip->dev->of_node); > } > Applied, thanks. Thierry [-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-03 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.so urceforge.net>
[not found] ` <5317A59D.4@users.sourceforge.net>
2015-02-03 10:58 ` [PATCH] pwm: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring
2015-02-03 11:57 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox