Linux PWM subsystem development
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] pwm: samsung: don't uses devm-functions in .request
Date: Thu, 9 May 2019 17:22:14 +0200	[thread overview]
Message-ID: <20190509152214.GF8907@ulmo> (raw)
In-Reply-To: <20190325094934.10221-2-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

On Mon, Mar 25, 2019 at 10:49:34AM +0100, Uwe Kleine-König wrote:
> A call to .request() is always paired by a call to .free() before a given
> device is disposed. So the simplification that usually is possible when
> using devm-functions cannot be used here. So use plain kzalloc() and
> kfree() for improved runtime behaviour and reduced memory footprint.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/pwm/pwm-samsung.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, and dropped the chip->dev parameter while at it to make this
actually build.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-05-09 15:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25  9:49 [PATCH 1/2] pwm: clear chip_data in pwm_put Uwe Kleine-König
2019-03-25  9:49 ` [PATCH 2/2] pwm: samsung: don't uses devm-functions in .request Uwe Kleine-König
2019-05-09 15:22   ` Thierry Reding [this message]
2019-05-09 19:02     ` Uwe Kleine-König
2019-05-09 15:21 ` [PATCH 1/2] pwm: clear chip_data in pwm_put Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190509152214.GF8907@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-pwm@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox