From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] pwm: samsung: don't uses devm-functions in .request
Date: Thu, 9 May 2019 21:02:15 +0200 [thread overview]
Message-ID: <20190509190215.74oj4orkntnpqfws@pengutronix.de> (raw)
In-Reply-To: <20190509152214.GF8907@ulmo>
On Thu, May 09, 2019 at 05:22:14PM +0200, Thierry Reding wrote:
> On Mon, Mar 25, 2019 at 10:49:34AM +0100, Uwe Kleine-König wrote:
> > A call to .request() is always paired by a call to .free() before a given
> > device is disposed. So the simplification that usually is possible when
> > using devm-functions cannot be used here. So use plain kzalloc() and
> > kfree() for improved runtime behaviour and reduced memory footprint.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/pwm/pwm-samsung.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Applied, and dropped the chip->dev parameter while at it to make this
> actually build.
Huh, thanks for that. I'm surprised I didn't notice that myself.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-05-09 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 9:49 [PATCH 1/2] pwm: clear chip_data in pwm_put Uwe Kleine-König
2019-03-25 9:49 ` [PATCH 2/2] pwm: samsung: don't uses devm-functions in .request Uwe Kleine-König
2019-05-09 15:22 ` Thierry Reding
2019-05-09 19:02 ` Uwe Kleine-König [this message]
2019-05-09 15:21 ` [PATCH 1/2] pwm: clear chip_data in pwm_put Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509190215.74oj4orkntnpqfws@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox