* [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() [not found] <20190730181557.90391-1-swboyd@chromium.org> @ 2019-07-30 18:15 ` Stephen Boyd 2019-07-31 6:58 ` Uwe Kleine-König 0 siblings, 1 reply; 4+ messages in thread From: Stephen Boyd @ 2019-07-30 18:15 UTC (permalink / raw) To: linux-kernel; +Cc: Thierry Reding, linux-pwm, Greg Kroah-Hartman We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Thierry Reding <thierry.reding@gmail.com> Cc: linux-pwm@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- Please apply directly to subsystem trees drivers/pwm/pwm-sti.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c index 20450e34ad57..1508616d794c 100644 --- a/drivers/pwm/pwm-sti.c +++ b/drivers/pwm/pwm-sti.c @@ -564,10 +564,8 @@ static int sti_pwm_probe(struct platform_device *pdev) return PTR_ERR(pc->regmap); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "Failed to obtain IRQ\n"); + if (irq < 0) return irq; - } ret = devm_request_irq(&pdev->dev, irq, sti_pwm_interrupt, 0, pdev->name, pc); -- Sent by a computer through tubes ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() 2019-07-30 18:15 ` [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() Stephen Boyd @ 2019-07-31 6:58 ` Uwe Kleine-König 2019-07-31 7:13 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: Uwe Kleine-König @ 2019-07-31 6:58 UTC (permalink / raw) To: Stephen Boyd; +Cc: linux-kernel, Thierry Reding, linux-pwm, Greg Kroah-Hartman On Tue, Jul 30, 2019 at 11:15:36AM -0700, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. Looking at v5.3-rc2 it's not obvious to me that all error paths of platform_get_irq issue an error message. Do I miss something? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() 2019-07-31 6:58 ` Uwe Kleine-König @ 2019-07-31 7:13 ` Greg Kroah-Hartman 2019-07-31 7:39 ` Uwe Kleine-König 0 siblings, 1 reply; 4+ messages in thread From: Greg Kroah-Hartman @ 2019-07-31 7:13 UTC (permalink / raw) To: Uwe Kleine-König Cc: Stephen Boyd, linux-kernel, Thierry Reding, linux-pwm On Wed, Jul 31, 2019 at 08:58:53AM +0200, Uwe Kleine-König wrote: > On Tue, Jul 30, 2019 at 11:15:36AM -0700, Stephen Boyd wrote: > > We don't need dev_err() messages when platform_get_irq() fails now that > > platform_get_irq() prints an error message itself when something goes > > wrong. Let's remove these prints with a simple semantic patch. > > Looking at v5.3-rc2 it's not obvious to me that all error paths of > platform_get_irq issue an error message. Do I miss something? The commit is in my driver-core tree at the moment, so this should wait until 5.4-rc1. I woudn't recommend merging it in 5.3-rc as it's not a bugfix. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() 2019-07-31 7:13 ` Greg Kroah-Hartman @ 2019-07-31 7:39 ` Uwe Kleine-König 0 siblings, 0 replies; 4+ messages in thread From: Uwe Kleine-König @ 2019-07-31 7:39 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Stephen Boyd, linux-kernel, Thierry Reding, linux-pwm On Wed, Jul 31, 2019 at 09:13:01AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 31, 2019 at 08:58:53AM +0200, Uwe Kleine-König wrote: > > On Tue, Jul 30, 2019 at 11:15:36AM -0700, Stephen Boyd wrote: > > > We don't need dev_err() messages when platform_get_irq() fails now that > > > platform_get_irq() prints an error message itself when something goes > > > wrong. Let's remove these prints with a simple semantic patch. > > > > Looking at v5.3-rc2 it's not obvious to me that all error paths of > > platform_get_irq issue an error message. Do I miss something? > > The commit is in my driver-core tree at the moment, so this should wait > until 5.4-rc1. I woudn't recommend merging it in 5.3-rc as it's not a > bugfix. As this is a new change pointing out its id in the commit log of the follow up changes might be beneficial. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-31 7:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190730181557.90391-1-swboyd@chromium.org>
2019-07-30 18:15 ` [PATCH v6 36/57] pwm: Remove dev_err() usage after platform_get_irq() Stephen Boyd
2019-07-31 6:58 ` Uwe Kleine-König
2019-07-31 7:13 ` Greg Kroah-Hartman
2019-07-31 7:39 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox