public inbox for linux-pwm@vger.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Lee Jones <lee.jones@linaro.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Fabrice Gasnier" <fabrice.gasnier@st.com>,
	linux-pwm@vger.kernel.org
Subject: [PATCH v2 0/3] pwm: stm32: Minor cleanups
Date: Wed, 16 Oct 2019 13:05:58 +0200	[thread overview]
Message-ID: <20191016110601.1765415-1-thierry.reding@gmail.com> (raw)

Hi,

Looking at Fabrice's STM32 patches I noticed that we're now passing the
breakinput values (u32) into a function via int parameters. The easiest
way to fix this inconsistency is by just passing a pointer to the break
input structure. There's some preparatory work here that makes the code
slightly more readable, in my opinion. I ended up squashing two patches
into one in v2 because the second patch from v1 is already addressed in
patch 1 of v2. I've added a patch in v2 that validates device tree data
for breakinput as suggested by Uwe.

Lee, patch 1 of this small series touches the MFD header for the STM32
timers, but there's no good way to separate the patches, so if you could
provide an Acked-by on that patch so that I can take it through the PWM
tree along with the rest, that'd be great.

Thierry

Thierry Reding (3):
  pwm: stm32: Remove clutter from ternary operator
  pwm: stm32: Pass breakinput instead of its values
  pwm: stm32: Validate breakinput data from DT

 drivers/pwm/pwm-stm32.c          | 36 +++++++++++++++++---------------
 include/linux/mfd/stm32-timers.h | 12 ++++-------
 2 files changed, 23 insertions(+), 25 deletions(-)

-- 
2.23.0

             reply	other threads:[~2019-10-16 11:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 11:05 Thierry Reding [this message]
2019-10-16 11:05 ` [PATCH v2 1/3] pwm: stm32: Remove clutter from ternary operator Thierry Reding
2019-10-16 11:11   ` Uwe Kleine-König
2019-10-16 13:06     ` Thierry Reding
2019-10-17  7:23   ` Lee Jones
2019-10-16 11:06 ` [PATCH v2 2/3] pwm: stm32: Pass breakinput instead of its values Thierry Reding
2019-10-16 11:13   ` Uwe Kleine-König
2019-10-16 11:06 ` [PATCH v2 3/3] pwm: stm32: Validate breakinput data from DT Thierry Reding
2019-10-16 11:15   ` Uwe Kleine-König
2019-10-16 13:07     ` Thierry Reding
2019-10-16 14:35       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016110601.1765415-1-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=fabrice.gasnier@st.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox