From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Fabrice Gasnier" <fabrice.gasnier@st.com>,
linux-pwm@vger.kernel.org
Subject: [PATCH v2 2/3] pwm: stm32: Pass breakinput instead of its values
Date: Wed, 16 Oct 2019 13:06:00 +0200 [thread overview]
Message-ID: <20191016110601.1765415-3-thierry.reding@gmail.com> (raw)
In-Reply-To: <20191016110601.1765415-1-thierry.reding@gmail.com>
Instead of passing the individual values of the breakpoint, pass a
pointer to the breakpoint.
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
drivers/pwm/pwm-stm32.c | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c
index a5b323432d8c..db1d675b45fb 100644
--- a/drivers/pwm/pwm-stm32.c
+++ b/drivers/pwm/pwm-stm32.c
@@ -491,18 +491,18 @@ static const struct pwm_ops stm32pwm_ops = {
};
static int stm32_pwm_set_breakinput(struct stm32_pwm *priv,
- int index, int level, int filter)
+ const struct stm32_breakinput *bi)
{
- u32 shift = TIM_BDTR_BKF_SHIFT(index);
- u32 bke = TIM_BDTR_BKE(index);
- u32 bkp = TIM_BDTR_BKP(index);
- u32 bkf = TIM_BDTR_BKF(index);
+ u32 shift = TIM_BDTR_BKF_SHIFT(bi->index);
+ u32 bke = TIM_BDTR_BKE(bi->index);
+ u32 bkp = TIM_BDTR_BKP(bi->index);
+ u32 bkf = TIM_BDTR_BKF(bi->index);
u32 mask = bkf | bkp | bke;
u32 bdtr;
- bdtr = (filter & TIM_BDTR_BKF_MASK) << shift | bke;
+ bdtr = (bi->filter & TIM_BDTR_BKF_MASK) << shift | bke;
- if (level)
+ if (bi->level)
bdtr |= bkp;
regmap_update_bits(priv->regmap, TIM_BDTR, mask, bdtr);
@@ -518,10 +518,7 @@ static int stm32_pwm_apply_breakinputs(struct stm32_pwm *priv)
int ret;
for (i = 0; i < priv->num_breakinputs; i++) {
- ret = stm32_pwm_set_breakinput(priv,
- priv->breakinputs[i].index,
- priv->breakinputs[i].level,
- priv->breakinputs[i].filter);
+ ret = stm32_pwm_set_breakinput(priv, &priv->breakinputs[i]);
if (ret < 0)
return ret;
}
--
2.23.0
next prev parent reply other threads:[~2019-10-16 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 11:05 [PATCH v2 0/3] pwm: stm32: Minor cleanups Thierry Reding
2019-10-16 11:05 ` [PATCH v2 1/3] pwm: stm32: Remove clutter from ternary operator Thierry Reding
2019-10-16 11:11 ` Uwe Kleine-König
2019-10-16 13:06 ` Thierry Reding
2019-10-17 7:23 ` Lee Jones
2019-10-16 11:06 ` Thierry Reding [this message]
2019-10-16 11:13 ` [PATCH v2 2/3] pwm: stm32: Pass breakinput instead of its values Uwe Kleine-König
2019-10-16 11:06 ` [PATCH v2 3/3] pwm: stm32: Validate breakinput data from DT Thierry Reding
2019-10-16 11:15 ` Uwe Kleine-König
2019-10-16 13:07 ` Thierry Reding
2019-10-16 14:35 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016110601.1765415-3-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=fabrice.gasnier@st.com \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox