Linux PWM subsystem development
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@sifive.com>
To: linux-pwm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	u.kleine-koenig@pengutronix.de,
	Thierry Reding <thierry.reding@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Greentime Hu <greentime.hu@sifive.com>,
	jarkko.nikula@linux.intel.com,
	William Salmon <william.salmon@sifive.com>,
	Jude Onyenegecha <jude.onyenegecha@sifive.com>,
	Ben Dooks <ben.dooks@sifive.com>
Subject: [PATCH v6 03/10] pwm: dwc: change &pci->dev to dev in probe
Date: Thu, 20 Oct 2022 16:16:03 +0100	[thread overview]
Message-ID: <20221020151610.59443-4-ben.dooks@sifive.com> (raw)
In-Reply-To: <20221020151610.59443-1-ben.dooks@sifive.com>

The dwc_pwm_probe() assignes dev to be &pci->dev but then uses
&pci->dev throughout the function. Change these all to the be
'dev' variable to make lines shorter.

Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-dwc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
index 7568300bb11e..c706ef9a7ba1 100644
--- a/drivers/pwm/pwm-dwc.c
+++ b/drivers/pwm/pwm-dwc.c
@@ -202,14 +202,13 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
 	struct dwc_pwm *dwc;
 	int ret;
 
-	dwc = devm_kzalloc(&pci->dev, sizeof(*dwc), GFP_KERNEL);
+	dwc = devm_kzalloc(dev, sizeof(*dwc), GFP_KERNEL);
 	if (!dwc)
 		return -ENOMEM;
 
 	ret = pcim_enable_device(pci);
 	if (ret) {
-		dev_err(&pci->dev,
-			"Failed to enable device (%pe)\n", ERR_PTR(ret));
+		dev_err(dev, "Failed to enable device (%pe)\n", ERR_PTR(ret));
 		return ret;
 	}
 
@@ -217,14 +216,13 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
 
 	ret = pcim_iomap_regions(pci, BIT(0), pci_name(pci));
 	if (ret) {
-		dev_err(&pci->dev,
-			"Failed to iomap PCI BAR (%pe)\n", ERR_PTR(ret));
+		dev_err(dev, "Failed to iomap PCI BAR (%pe)\n", ERR_PTR(ret));
 		return ret;
 	}
 
 	dwc->base = pcim_iomap_table(pci)[0];
 	if (!dwc->base) {
-		dev_err(&pci->dev, "Base address missing\n");
+		dev_err(dev, "Base address missing\n");
 		return -ENOMEM;
 	}
 
-- 
2.35.1


  parent reply	other threads:[~2022-10-20 15:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 15:16 [PATCH v6 00/10] Designware PWM driver updates for OF Ben Dooks
2022-10-20 15:16 ` [PATCH v6 01/10] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm-dw-apb-timers-pwm2 Ben Dooks
2022-10-20 15:36   ` Krzysztof Kozlowski
2022-10-24 15:45     ` Ben Dooks
2022-10-20 15:39   ` Uwe Kleine-König
2022-11-17 16:10   ` Uwe Kleine-König
2022-10-20 15:16 ` [PATCH v6 02/10] pwm: dwc: allow driver to be built with COMPILE_TEST Ben Dooks
2022-10-20 15:51   ` Uwe Kleine-König
2022-10-20 15:16 ` Ben Dooks [this message]
2022-10-20 15:16 ` [PATCH v6 04/10] pwm: dwc: move memory alloc to own function Ben Dooks
2022-11-10 15:35   ` Uwe Kleine-König
2022-10-20 15:16 ` [PATCH v6 05/10] pwm: dwc: use devm_pwmchip_add Ben Dooks
2022-10-20 15:55   ` Uwe Kleine-König
2022-10-20 15:16 ` [PATCH v6 06/10] pwm: dwc: split pci out of core driver Ben Dooks
2022-11-10 15:29   ` Uwe Kleine-König
2022-11-10 16:35     ` Ben Dooks
2022-11-17 16:15       ` Uwe Kleine-König
2022-10-20 15:16 ` [PATCH v6 07/10] pwm: dwc: make timer clock configurable Ben Dooks
2022-11-10 15:39   ` Uwe Kleine-König
2022-10-20 15:16 ` [PATCH v6 08/10] pwm: dwc: add of/platform support Ben Dooks
2022-10-20 15:16 ` [PATCH v6 09/10] pwm: dwc: add PWM bit unset in get_state call Ben Dooks
2022-10-20 15:16 ` [PATCH v6 10/10] pwm: dwc: use clock rate in hz to avoid rounding issues Ben Dooks
2022-11-10 15:42   ` Uwe Kleine-König
2022-11-10 16:29     ` Ben Dooks
2022-10-24  8:39 ` [PATCH v6 00/10] Designware PWM driver updates for OF Jarkko Nikula
2022-10-24 15:40   ` Ben Dooks
2022-11-08 11:19   ` Ben Dooks
2022-11-08 11:48     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020151610.59443-4-ben.dooks@sifive.com \
    --to=ben.dooks@sifive.com \
    --cc=devicetree@vger.kernel.org \
    --cc=greentime.hu@sifive.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jude.onyenegecha@sifive.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=william.salmon@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox