* [PATCH 09/36] gpio: mvebu: use new pinctrl GPIO helpers [not found] <20231003145114.21637-1-brgl@bgdev.pl> @ 2023-10-03 14:50 ` Bartosz Golaszewski 2023-10-09 9:44 ` Uwe Kleine-König 0 siblings, 1 reply; 2+ messages in thread From: Bartosz Golaszewski @ 2023-10-03 14:50 UTC (permalink / raw) To: Linus Walleij, Andy Shevchenko Cc: linux-gpio, linux-kernel, Bartosz Golaszewski, Thierry Reding, Uwe Kleine-König, linux-pwm From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Replace the pinctrl helpers taking the global GPIO number as argument with the improved variants that instead take a pointer to the GPIO chip and the controller-relative offset. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- drivers/gpio/gpio-mvebu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 67497116ce27..8fada9cd258a 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -345,7 +345,7 @@ static int mvebu_gpio_direction_input(struct gpio_chip *chip, unsigned int pin) * Check with the pinctrl driver whether this pin is usable as * an input GPIO */ - ret = pinctrl_gpio_direction_input(chip->base + pin); + ret = pinctrl_gpio_direction_input_new(chip, pin); if (ret) return ret; @@ -365,7 +365,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin, * Check with the pinctrl driver whether this pin is usable as * an output GPIO */ - ret = pinctrl_gpio_direction_output(chip->base + pin); + ret = pinctrl_gpio_direction_output_new(chip, pin); if (ret) return ret; -- 2.39.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 09/36] gpio: mvebu: use new pinctrl GPIO helpers 2023-10-03 14:50 ` [PATCH 09/36] gpio: mvebu: use new pinctrl GPIO helpers Bartosz Golaszewski @ 2023-10-09 9:44 ` Uwe Kleine-König 0 siblings, 0 replies; 2+ messages in thread From: Uwe Kleine-König @ 2023-10-09 9:44 UTC (permalink / raw) To: Bartosz Golaszewski Cc: Linus Walleij, Andy Shevchenko, linux-gpio, linux-kernel, Bartosz Golaszewski, Thierry Reding, linux-pwm [-- Attachment #1: Type: text/plain, Size: 729 bytes --] Hello Bartosz, On Tue, Oct 03, 2023 at 04:50:47PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Replace the pinctrl helpers taking the global GPIO number as argument > with the improved variants that instead take a pointer to the GPIO chip > and the controller-relative offset. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Looks good (after I found the cover letter which luckily is easy). Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-09 9:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231003145114.21637-1-brgl@bgdev.pl>
2023-10-03 14:50 ` [PATCH 09/36] gpio: mvebu: use new pinctrl GPIO helpers Bartosz Golaszewski
2023-10-09 9:44 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox