Re: [PATCH v2] dt-bindings: pwm: Convert lpc32xx-pwm.txt to YAML

[Purva Yeshi <purvayeshi550@gmail.com>]

On 03/04/25 16:11, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Mar 12, 2025 at 05:57:50PM +0530, Purva Yeshi wrote:
>> Convert the existing `lpc32xx-pwm.txt` bindings documentation into a
>> YAML schema (`nxp,lpc3220-pwm.yaml`).
>>
>> Set `"#pwm-cells"` to `const: 3` for expected PWM cell properties.
>>
>> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
> 
> I suggest the following commit log:
> 
>      dt-bindings: pwm: Convert lpc32xx-pwm.txt to yaml format
> 
>      Convert the existing plain text binding documentation for
>      nxp,lpc3220-pwm devices to a YAML schema.
> 
>      The value #pwm-cells wasn't specified before, set it to 3 to match the
>      usual value for PWMs.
> 

Hello,

Thank you for the suggestion. I'll update the commit log accordingly in 
the next revision.

>> diff --git a/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
>> new file mode 100644
>> index 000000000..432a5e9d4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/nxp,lpc3220-pwm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: LPC32XX PWM controller
>> +
>> +maintainers:
>> +  - Vladimir Zapolskiy <vz@mleia.com>
>> +  - Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>
>> +
>> +allOf:
>> +  - $ref: pwm.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: nxp,lpc3220-pwm
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  "#pwm-cells":
>> +    const: 3
> 
> The PWMs defined in arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi also have a
> clocks property and in the driver it's not optional. Can you please add
> it (here, in the list of required properties and the commit log)?

Thank you for the review. I’ll add the clocks property, update the list 
of required properties, and adjust the commit log accordingly in the 
next revision.

> 
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    pwm@4005c000 {
>> +        compatible = "nxp,lpc3220-pwm";
>> +        reg = <0x4005c000 0x4>;
>> +        #pwm-cells = <3>;
>> +    };
> 
> Best regards
> Uwe

Best regards,
Purva Yeshi