From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
johan@kernel.org, elder@kernel.org, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, greybus-dev@lists.linaro.org,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: remove unnecessary blank line
Date: Sun, 19 Mar 2023 18:15:55 +0200 [thread overview]
Message-ID: <62070f52-1600-1a6f-b7e5-6fb6850840c4@gmail.com> (raw)
In-Reply-To: <1775403.TLkxdtWsSY@suse>
On ١٩/٣/٢٠٢٣ ١٨:٠٩, Fabio M. De Francesco wrote:
>
> On domenica 19 marzo 2023 16:29:09 CET Menna Mahmoud wrote:
>
> > Remove unnecessary blank line before struct as reported
>
> > by checkpatch:
>
> >
>
> > " CHECK: Please don't use multiple blank lines "
>
> >
>
> > Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>
> > ---
>
> > drivers/staging/greybus/pwm.c | 1 -
>
> > 1 file changed, 1 deletion(-)
>
> >
>
> > diff --git a/drivers/staging/greybus/pwm.c
> b/drivers/staging/greybus/pwm.c
>
> > index 3fda172239d2..26d39e08c3b6 100644
>
> > --- a/drivers/staging/greybus/pwm.c
>
> > +++ b/drivers/staging/greybus/pwm.c
>
> > @@ -24,7 +24,6 @@ struct gb_pwm_chip {
>
> > #define pwm_chip_to_gb_pwm_chip(chip) \
>
> > container_of(chip, struct gb_pwm_chip, chip)
>
> >
>
> > -
>
> > static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
>
> > {
>
> > struct gb_pwm_count_response response;
>
> > --
>
> > 2.34.1
>
>
> Hi Menna,
>
>
Hi Fabio,
> I just saw that today you sent this patch at least three times:
>
>
> https://lore.kernel.org/linux-staging/20230319114155.42148-2-eng.mennamahmoud.mm@gmail.com/
>
This for different file, and the below I sent it with other patch so I
resend it again.
>
> https://lore.kernel.org/linux-staging/20230319152909.163598-1-eng.mennamahmoud.mm@gmail.com/
>
>
> https://lore.kernel.org/linux-staging/20230319132452.151877-2-eng.mennamahmoud.mm@gmail.com/
>
>
> Why are you doing so?
>
sorry for this.
>
> Please send your patches only once and wait at least a week without
> any replies before resending. Furthermore, when resending, please
> explain under the three dashes ("---") why you are doing so. Patches
> may get lost, but this is not your case for sending them again and
> again in a single day.
>
got your point.
>
> Is there anything I'm missing?
>
>
> Thanks,
>
>
> Fabio
>
>
>
Thanks,
Menna
next prev parent reply other threads:[~2023-03-19 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 15:29 [PATCH] staging: greybus: remove unnecessary blank line Menna Mahmoud
[not found] ` <1775403.TLkxdtWsSY@suse>
2023-03-19 16:15 ` Menna Mahmoud [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-22 10:09 Menna Mahmoud
2023-03-22 10:14 ` Julia Lawall
2023-03-22 10:16 ` Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62070f52-1600-1a6f-b7e5-6fb6850840c4@gmail.com \
--to=eng.mennamahmoud.mm@gmail.com \
--cc=elder@kernel.org \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox