From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
johan@kernel.org, elder@kernel.org, vireshk@kernel.org,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: remove unnecessary blank line
Date: Wed, 22 Mar 2023 12:16:44 +0200 [thread overview]
Message-ID: <9e339ec0-d244-ea22-d9d8-70a76ac1bc0a@gmail.com> (raw)
In-Reply-To: <369edb35-b93b-301c-fcef-8e64e5d4a122@inria.fr>
On ٢٢/٣/٢٠٢٣ ١٢:١٤, Julia Lawall wrote:
>
> On Wed, 22 Mar 2023, Menna Mahmoud wrote:
>
>> Remove unnecessary blank line before struct as reported
>> by checkpatch:
>>
>> " CHECK: Please don't use multiple blank lines"
> Since there is no vX indicator, one doesn't know that this replaces some
> previous patches.
yes, sorry I missed it because I dropped the previous commits, I will
add it.
Menna
>
> julia
>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>> ---
>> drivers/staging/greybus/greybus_authentication.h | 1 -
>> drivers/staging/greybus/pwm.c | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
>> index 7edc7295b7ab..48b4a9794d3c 100644
>> --- a/drivers/staging/greybus/greybus_authentication.h
>> +++ b/drivers/staging/greybus/greybus_authentication.h
>> @@ -41,7 +41,6 @@
>> #define CAP_AUTH_RESULT_CR_NO_KEY 0x03
>> #define CAP_AUTH_RESULT_CR_SIG_FAIL 0x04
>>
>> -
>> /* IOCTL support */
>> struct cap_ioc_get_endpoint_uid {
>> __u8 uid[8];
>> diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
>> index 3fda172239d2..26d39e08c3b6 100644
>> --- a/drivers/staging/greybus/pwm.c
>> +++ b/drivers/staging/greybus/pwm.c
>> @@ -24,7 +24,6 @@ struct gb_pwm_chip {
>> #define pwm_chip_to_gb_pwm_chip(chip) \
>> container_of(chip, struct gb_pwm_chip, chip)
>>
>> -
>> static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
>> {
>> struct gb_pwm_count_response response;
>> --
>> 2.34.1
>>
>>
>>
next prev parent reply other threads:[~2023-03-22 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 10:09 [PATCH] staging: greybus: remove unnecessary blank line Menna Mahmoud
2023-03-22 10:14 ` Julia Lawall
2023-03-22 10:16 ` Menna Mahmoud [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-19 15:29 Menna Mahmoud
[not found] ` <1775403.TLkxdtWsSY@suse>
2023-03-19 16:15 ` Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e339ec0-d244-ea22-d9d8-70a76ac1bc0a@gmail.com \
--to=eng.mennamahmoud.mm@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox