[PATCH] staging: greybus: remove unnecessary blank line

Linux PWM subsystem development
 help / color / mirror / Atom feed

* [PATCH] staging: greybus: remove unnecessary blank line
@ 2023-03-22 10:09 Menna Mahmoud
  2023-03-22 10:14 ` Julia Lawall
  0 siblings, 1 reply; 5+ messages in thread
From: Menna Mahmoud @ 2023-03-22 10:09 UTC (permalink / raw)
  To: gregkh
  Cc: outreachy, johan, elder, vireshk, thierry.reding, u.kleine-koenig,
	greybus-dev, linux-kernel, linux-staging, linux-pwm,
	eng.mennamahmoud.mm

Remove unnecessary blank line before struct as reported
by checkpatch:

" CHECK: Please don't use multiple blank lines "

Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
---
 drivers/staging/greybus/greybus_authentication.h | 1 -
 drivers/staging/greybus/pwm.c                    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
index 7edc7295b7ab..48b4a9794d3c 100644
--- a/drivers/staging/greybus/greybus_authentication.h
+++ b/drivers/staging/greybus/greybus_authentication.h
@@ -41,7 +41,6 @@
 #define CAP_AUTH_RESULT_CR_NO_KEY	0x03
 #define CAP_AUTH_RESULT_CR_SIG_FAIL	0x04
 
-
 /* IOCTL support */
 struct cap_ioc_get_endpoint_uid {
 	__u8			uid[8];
diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
index 3fda172239d2..26d39e08c3b6 100644
--- a/drivers/staging/greybus/pwm.c
+++ b/drivers/staging/greybus/pwm.c
@@ -24,7 +24,6 @@ struct gb_pwm_chip {
 #define pwm_chip_to_gb_pwm_chip(chip) \
 	container_of(chip, struct gb_pwm_chip, chip)
 
-
 static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
 {
 	struct gb_pwm_count_response response;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: greybus: remove unnecessary blank line
  2023-03-22 10:09 [PATCH] staging: greybus: remove unnecessary blank line Menna Mahmoud
@ 2023-03-22 10:14 ` Julia Lawall
  2023-03-22 10:16   ` Menna Mahmoud
  0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2023-03-22 10:14 UTC (permalink / raw)
  To: Menna Mahmoud
  Cc: gregkh, outreachy, johan, elder, vireshk, thierry.reding,
	u.kleine-koenig, greybus-dev, linux-kernel, linux-staging,
	linux-pwm



On Wed, 22 Mar 2023, Menna Mahmoud wrote:

> Remove unnecessary blank line before struct as reported
> by checkpatch:
>
> " CHECK: Please don't use multiple blank lines "

Since there is no vX indicator, one doesn't know that this replaces some
previous patches.

julia

>
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
> ---
>  drivers/staging/greybus/greybus_authentication.h | 1 -
>  drivers/staging/greybus/pwm.c                    | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
> index 7edc7295b7ab..48b4a9794d3c 100644
> --- a/drivers/staging/greybus/greybus_authentication.h
> +++ b/drivers/staging/greybus/greybus_authentication.h
> @@ -41,7 +41,6 @@
>  #define CAP_AUTH_RESULT_CR_NO_KEY	0x03
>  #define CAP_AUTH_RESULT_CR_SIG_FAIL	0x04
>
> -
>  /* IOCTL support */
>  struct cap_ioc_get_endpoint_uid {
>  	__u8			uid[8];
> diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
> index 3fda172239d2..26d39e08c3b6 100644
> --- a/drivers/staging/greybus/pwm.c
> +++ b/drivers/staging/greybus/pwm.c
> @@ -24,7 +24,6 @@ struct gb_pwm_chip {
>  #define pwm_chip_to_gb_pwm_chip(chip) \
>  	container_of(chip, struct gb_pwm_chip, chip)
>
> -
>  static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
>  {
>  	struct gb_pwm_count_response response;
> --
> 2.34.1
>
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: greybus: remove unnecessary blank line
  2023-03-22 10:14 ` Julia Lawall
@ 2023-03-22 10:16   ` Menna Mahmoud
  0 siblings, 0 replies; 5+ messages in thread
From: Menna Mahmoud @ 2023-03-22 10:16 UTC (permalink / raw)
  To: Julia Lawall
  Cc: gregkh, outreachy, johan, elder, vireshk, thierry.reding,
	u.kleine-koenig, greybus-dev, linux-kernel, linux-staging,
	linux-pwm


On ٢٢‏/٣‏/٢٠٢٣ ١٢:١٤, Julia Lawall wrote:
>
> On Wed, 22 Mar 2023, Menna Mahmoud wrote:
>
>> Remove unnecessary blank line before struct as reported
>> by checkpatch:
>>
>> " CHECK: Please don't use multiple blank lines"
> Since there is no vX indicator, one doesn't know that this replaces some
> previous patches.

yes, sorry I missed it because I dropped the previous commits, I will 
add it.


Menna

>
> julia
>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>> ---
>>   drivers/staging/greybus/greybus_authentication.h | 1 -
>>   drivers/staging/greybus/pwm.c                    | 1 -
>>   2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
>> index 7edc7295b7ab..48b4a9794d3c 100644
>> --- a/drivers/staging/greybus/greybus_authentication.h
>> +++ b/drivers/staging/greybus/greybus_authentication.h
>> @@ -41,7 +41,6 @@
>>   #define CAP_AUTH_RESULT_CR_NO_KEY	0x03
>>   #define CAP_AUTH_RESULT_CR_SIG_FAIL	0x04
>>
>> -
>>   /* IOCTL support */
>>   struct cap_ioc_get_endpoint_uid {
>>   	__u8			uid[8];
>> diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
>> index 3fda172239d2..26d39e08c3b6 100644
>> --- a/drivers/staging/greybus/pwm.c
>> +++ b/drivers/staging/greybus/pwm.c
>> @@ -24,7 +24,6 @@ struct gb_pwm_chip {
>>   #define pwm_chip_to_gb_pwm_chip(chip) \
>>   	container_of(chip, struct gb_pwm_chip, chip)
>>
>> -
>>   static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
>>   {
>>   	struct gb_pwm_count_response response;
>> --
>> 2.34.1
>>
>>
>>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] staging: greybus: remove unnecessary blank line
@ 2023-03-19 15:29 Menna Mahmoud
       [not found] ` <1775403.TLkxdtWsSY@suse>
  0 siblings, 1 reply; 5+ messages in thread
From: Menna Mahmoud @ 2023-03-19 15:29 UTC (permalink / raw)
  To: gregkh
  Cc: outreachy, johan, elder, thierry.reding, u.kleine-koenig,
	greybus-dev, linux-pwm, linux-kernel, linux-staging,
	eng.mennamahmoud.mm

Remove unnecessary blank line before struct as reported
by checkpatch:

" CHECK: Please don't use multiple blank lines "

Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
---
 drivers/staging/greybus/pwm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
index 3fda172239d2..26d39e08c3b6 100644
--- a/drivers/staging/greybus/pwm.c
+++ b/drivers/staging/greybus/pwm.c
@@ -24,7 +24,6 @@ struct gb_pwm_chip {
 #define pwm_chip_to_gb_pwm_chip(chip) \
 	container_of(chip, struct gb_pwm_chip, chip)
 
-
 static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
 {
 	struct gb_pwm_count_response response;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

[parent not found: <1775403.TLkxdtWsSY@suse>]

* Re: [PATCH] staging: greybus: remove unnecessary blank line
       [not found] ` <1775403.TLkxdtWsSY@suse>
@ 2023-03-19 16:15   ` Menna Mahmoud
  0 siblings, 0 replies; 5+ messages in thread
From: Menna Mahmoud @ 2023-03-19 16:15 UTC (permalink / raw)
  To: Fabio M. De Francesco
  Cc: gregkh, outreachy, johan, elder, thierry.reding, u.kleine-koenig,
	greybus-dev, linux-pwm, linux-kernel, linux-staging


On ١٩‏/٣‏/٢٠٢٣ ١٨:٠٩, Fabio M. De Francesco wrote:
>
> On domenica 19 marzo 2023 16:29:09 CET Menna Mahmoud wrote:
>
> > Remove unnecessary blank line before struct as reported
>
> > by checkpatch:
>
> >
>
> > " CHECK: Please don't use multiple blank lines "
>
> >
>
> > Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>
> > ---
>
> > drivers/staging/greybus/pwm.c | 1 -
>
> > 1 file changed, 1 deletion(-)
>
> >
>
> > diff --git a/drivers/staging/greybus/pwm.c 
> b/drivers/staging/greybus/pwm.c
>
> > index 3fda172239d2..26d39e08c3b6 100644
>
> > --- a/drivers/staging/greybus/pwm.c
>
> > +++ b/drivers/staging/greybus/pwm.c
>
> > @@ -24,7 +24,6 @@ struct gb_pwm_chip {
>
> > #define pwm_chip_to_gb_pwm_chip(chip) \
>
> >     container_of(chip, struct gb_pwm_chip, chip)
>
> >
>
> > -
>
> > static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
>
> > {
>
> >     struct gb_pwm_count_response response;
>
> > --
>
> > 2.34.1
>
>
> Hi Menna,
>
>
Hi Fabio,


> I just saw that today you sent this patch at least three times:
>
>
> https://lore.kernel.org/linux-staging/20230319114155.42148-2-eng.mennamahmoud.mm@gmail.com/
>

This for different file, and the below I sent it with other patch so I 
resend it again.

>
> https://lore.kernel.org/linux-staging/20230319152909.163598-1-eng.mennamahmoud.mm@gmail.com/
>
>
> https://lore.kernel.org/linux-staging/20230319132452.151877-2-eng.mennamahmoud.mm@gmail.com/
>
>
> Why are you doing so?
>

sorry for this.

>
> Please send your patches only once and wait at least a week without 
> any replies before resending. Furthermore, when resending, please 
> explain under the three dashes ("---") why you are doing so. Patches 
> may get lost, but this is not your case for sending them again and 
> again in a single day.
>
got your point.

>
> Is there anything I'm missing?
>
>
> Thanks,
>
>
> Fabio
>
>
>

Thanks,

Menna


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-22 10:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-22 10:09 [PATCH] staging: greybus: remove unnecessary blank line Menna Mahmoud
2023-03-22 10:14 ` Julia Lawall
2023-03-22 10:16   ` Menna Mahmoud
  -- strict thread matches above, loose matches on Subject: below --
2023-03-19 15:29 Menna Mahmoud
     [not found] ` <1775403.TLkxdtWsSY@suse>
2023-03-19 16:15   ` Menna Mahmoud

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox