From: Michael Walle <michael@walle.cc>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 09/10] pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
Date: Wed, 19 Jul 2023 16:55:31 +0200 [thread overview]
Message-ID: <9cb1b141e206dd9afd215d8886d688d9@walle.cc> (raw)
In-Reply-To: <20230719143956.6sv3feiroiwrcosb@pengutronix.de>
Hi,
>> I'd expect it to be:
>> #define sl28cpld_pwm_from_chip(_chip) \
>> container_of(_chip, struct sl28cpld_pwm, chip)
>
> Indeed, that's bogus. My preference would be to make this a static
> inline, i.e.
>
> diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c
> index 98b0024f9658..c789e934671e 100644
> --- a/drivers/pwm/pwm-sl28cpld.c
> +++ b/drivers/pwm/pwm-sl28cpld.c
> @@ -84,8 +84,11 @@ struct sl28cpld_pwm {
> struct regmap *regmap;
> u32 offset;
> };
> -#define sl28cpld_pwm_from_chip(chip) \
> - container_of(chip, struct sl28cpld_pwm, chip)
> +
> +static inline struct sl28cpld_pwm *sl28cpld_pwm_from_chip(struct
> pwm_chip *chip)
> +{
> + return container_of(chip, struct sl28cpld_pwm, chip);
> +}
>
> static int sl28cpld_pwm_get_state(struct pwm_chip *chip,
> struct pwm_device *pwm,
>
> but I can live with _chip, too.
I don't have a strong preference. Looks like most drivers use
the inline. Go with that :)
-michael
next prev parent reply other threads:[~2023-07-19 14:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 01/10] pwm: Use a consistent name for pwm_chip pointers in the core Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming Uwe Kleine-König
2023-07-16 13:04 ` claudiu beznea
2023-07-20 6:53 ` Thierry Reding
2023-07-20 7:29 ` Uwe Kleine-König
2023-07-21 17:58 ` Uwe Kleine-König
2023-07-21 18:26 ` Thierry Reding
2023-07-14 20:56 ` [PATCH 03/10] pwm: bcm-kona: Consistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 04/10] pwm: crc: " Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 05/10] pwm: cros-ec: " Uwe Kleine-König
2023-07-17 3:34 ` Tzung-Bi Shih
2023-07-14 20:56 ` [PATCH 06/10] pwm: lp3943: " Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 07/10] pwm: rockchip: " Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 08/10] pwm: sifive: " Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 09/10] pwm: sl28cpld: " Uwe Kleine-König
2023-07-19 14:17 ` Michael Walle
2023-07-19 14:39 ` Uwe Kleine-König
2023-07-19 14:55 ` Michael Walle [this message]
2023-07-14 20:56 ` [PATCH 10/10] staging: greybus: pwm: " Uwe Kleine-König
2023-07-15 15:04 ` Alex Elder
2023-07-20 6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
2023-07-20 7:10 ` Uwe Kleine-König
2023-07-20 15:03 ` Thierry Reding
2023-07-20 14:41 ` Thierry Reding
2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cb1b141e206dd9afd215d8886d688d9@walle.cc \
--to=michael@walle.cc \
--cc=kernel@pengutronix.de \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox