Re: [PATCH 09/10] pwm: sl28cpld: Consistenly name pwm_chip variables "chip"

[Michael Walle <michael@walle.cc>]

Hi,

Am 2023-07-14 22:56, schrieb Uwe Kleine-König:
> Nearly all pwm drivers use the name "chip" for the member in the driver
> struct pointing to the pwm_chip. Also all local variables and function
> parameters with this type use this name. Rename the struct pwm_chip
> member accordingly for consistency.
> 
> Also rename the parameter of the macro sl28cpld_pwm_from_chip to 
> "chip".
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> ---

> -#define sl28cpld_pwm_from_chip(_chip) \
> -	container_of(_chip, struct sl28cpld_pwm, pwm_chip)
> +#define sl28cpld_pwm_from_chip(chip) \
> +	container_of(chip, struct sl28cpld_pwm, chip)

This looks strange now. Before only the the first parameter of
container_of() is a parameter of the macro. After the change
it's the first and the last. I.e. the name of the member
comes from the argument of the macro.

Was that intended? Looks like it happens to work because
everything is named "chip", but nevertheless it doesn't look
correct to me.

I'd expect it to be:
#define sl28cpld_pwm_from_chip(_chip) \
	container_of(_chip, struct sl28cpld_pwm, chip)

-michael