* [PATCH] pwm: Drop unused #include <linux/radix-tree.h>
@ 2023-07-28 7:12 Uwe Kleine-König
2023-07-28 7:30 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2023-07-28 7:12 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-pwm, kernel
core.c doens't use any of the symbols provided by linux/radix-tree.h
and compiles just fine without this include. So drop the #include.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/pwm/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 3dacceaef4a9..5b0794858ad4 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -9,7 +9,6 @@
#include <linux/acpi.h>
#include <linux/module.h>
#include <linux/pwm.h>
-#include <linux/radix-tree.h>
#include <linux/list.h>
#include <linux/mutex.h>
#include <linux/err.h>
base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: Drop unused #include <linux/radix-tree.h>
2023-07-28 7:12 [PATCH] pwm: Drop unused #include <linux/radix-tree.h> Uwe Kleine-König
@ 2023-07-28 7:30 ` Thierry Reding
2023-07-28 7:59 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2023-07-28 7:30 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-pwm, kernel
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Fri, Jul 28, 2023 at 09:12:59AM +0200, Uwe Kleine-König wrote:
> core.c doens't use any of the symbols provided by linux/radix-tree.h
> and compiles just fine without this include. So drop the #include.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pwm/core.c | 1 -
> 1 file changed, 1 deletion(-)
Looks like I forgot to remove that when the radix tree support was
dropped in 247ee6c780406513c6031a7f4ea41f1648b03295. This didn't apply
cleanly, so it breaks the b4 tracking.
Applied, thanks.
Thierry
>
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 3dacceaef4a9..5b0794858ad4 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -9,7 +9,6 @@
> #include <linux/acpi.h>
> #include <linux/module.h>
> #include <linux/pwm.h>
> -#include <linux/radix-tree.h>
> #include <linux/list.h>
> #include <linux/mutex.h>
> #include <linux/err.h>
>
> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: Drop unused #include <linux/radix-tree.h>
2023-07-28 7:30 ` Thierry Reding
@ 2023-07-28 7:59 ` Uwe Kleine-König
0 siblings, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2023-07-28 7:59 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-pwm, kernel
[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]
On Fri, Jul 28, 2023 at 09:30:13AM +0200, Thierry Reding wrote:
> On Fri, Jul 28, 2023 at 09:12:59AM +0200, Uwe Kleine-König wrote:
> > core.c doens't use any of the symbols provided by linux/radix-tree.h
> > and compiles just fine without this include. So drop the #include.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/pwm/core.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Looks like I forgot to remove that when the radix tree support was
> dropped in 247ee6c780406513c6031a7f4ea41f1648b03295. This didn't apply
> cleanly, so it breaks the b4 tracking.
Ah right, I based it on v6.5-rc1 while it conflicts with commit
0a41b0c5d97a ("pwm: Explicitly include correct DT includes"). If you
pass -3 to git am, it applies fine though.
I don't know what you mean by "b4 tracking", maybe git am -3 fixes that,
too?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-28 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 7:12 [PATCH] pwm: Drop unused #include <linux/radix-tree.h> Uwe Kleine-König
2023-07-28 7:30 ` Thierry Reding
2023-07-28 7:59 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox