From: Andy Shevchenko <andy@kernel.org>
To: Li Zetao <lizetao1@huawei.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, j-keerthy@ti.com,
vz@mleia.com, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, grygorii.strashko@ti.com,
ssantosh@kernel.org, khilman@kernel.org,
shubhrajyoti.datta@amd.com, srinivas.neeli@amd.com,
michal.simek@amd.com, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH -next 08/11] gpio: omap: Use helper function devm_clk_get_prepared()
Date: Fri, 18 Aug 2023 18:00:22 +0300 [thread overview]
Message-ID: <ZN+HhgS2Qgrn9mt3@smile.fi.intel.com> (raw)
In-Reply-To: <20230818093018.1051434-9-lizetao1@huawei.com>
On Fri, Aug 18, 2023 at 05:30:15PM +0800, Li Zetao wrote:
> Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for
> prepared and enabled clocks"), devm_clk_get() and clk_prepare() can now be
> replaced by devm_clk_get_prepared() when the driver enables (and possibly
> prepares) the clocks for the whole lifetime of the device. Moreover, it is
> no longer necessary to unprepare and disable the clocks explicitly.
The commit message isn't correct. Seems you copied'n'pasted from other cases.
Please, revisit.
Code wise looks legit to me.
With the commit message fixed
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-18 15:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 9:30 [PATCH -next 00/11] gpio: Use devm_clk_get_*() helper function to simplify the drivers Li Zetao
2023-08-18 9:30 ` [PATCH -next 01/11] gpio: cadence: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-18 13:49 ` Andy Shevchenko
2023-08-18 9:30 ` [PATCH -next 02/11] gpio: davinci: " Li Zetao
2023-08-18 14:03 ` Andy Shevchenko
2023-08-18 9:30 ` [PATCH -next 03/11] gpio: ftgpio010: " Li Zetao
2023-08-18 13:47 ` Andy Shevchenko
2023-08-18 9:30 ` [PATCH -next 04/11] gpio: lpc18xx: " Li Zetao
2023-08-18 14:07 ` Andy Shevchenko
2023-08-18 9:30 ` [PATCH -next 05/11] gpio: mb86s7x: Use helper function devm_clk_get_optional_enabled() Li Zetao
2023-08-18 14:09 ` Andy Shevchenko
2023-08-18 9:30 ` [PATCH -next 06/11] gpio: mvebu: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-18 13:55 ` Andy Shevchenko
2023-08-18 9:30 ` [PATCH -next 07/11] gpio: mxc: Use helper function devm_clk_get_optional_enabled() Li Zetao
2023-08-18 13:59 ` Andy Shevchenko
2023-08-21 12:12 ` Bartosz Golaszewski
2023-08-18 9:30 ` [PATCH -next 08/11] gpio: omap: Use helper function devm_clk_get_prepared() Li Zetao
2023-08-18 15:00 ` Andy Shevchenko [this message]
2023-08-18 9:30 ` [PATCH -next 09/11] gpio: stp-xway: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-18 15:11 ` Andy Shevchenko
2023-08-18 9:30 ` [PATCH -next 10/11] gpio: xilinx: Use helper function devm_clk_get_optional_enabled() Li Zetao
2023-08-18 15:12 ` Andy Shevchenko
2023-08-18 9:30 ` [PATCH -next 11/11] gpio: zynq: Use helper function devm_clk_get_enabled() Li Zetao
2023-08-18 15:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN+HhgS2Qgrn9mt3@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=michal.simek@amd.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
--cc=ssantosh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox