* [KJ] [PATCH] is_power_of_2 in md
@ 2007-02-16 12:05 Vignesh Babu BM
0 siblings, 0 replies; only message in thread
From: Vignesh Babu BM @ 2007-02-16 12:05 UTC (permalink / raw)
To: Kernel Janitors List; +Cc: neilb, linux-raid, mingo
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c
index 0821a2b..f2d4b23 100644
--- a/drivers/md/dm-snap.c
+++ b/drivers/md/dm-snap.c
@@ -17,6 +17,7 @@
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/vmalloc.h>
+#include <linux/log2.h>
#include "dm-snap.h"
#include "dm-bio-list.h"
@@ -414,7 +415,7 @@ static int set_chunk_size(struct dm_snapshot *s, const char *chunk_size_arg,
chunk_size = round_up(chunk_size, PAGE_SIZE >> 9);
/* Check chunk_size is a power of 2 */
- if (chunk_size & (chunk_size - 1)) {
+ if (!is_power_of_2(chunk_size)) {
*error = "Chunk size is not a power of 2";
return -EINVAL;
}
--
Regards,
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-02-16 12:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-16 12:05 [KJ] [PATCH] is_power_of_2 in md Vignesh Babu BM
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox