[PATCH] Grow: don't allow to enable PPL when reshape is in progress

[PATCH] Grow: don't allow to enable PPL when reshape is in progress

[Tomasz Majchrzak]

Don't allow to enable PPL consistency policy when reshape is in progress.
Current PPL implementation doesn't work when reshape is taking place.

Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
---
 Grow.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Grow.c b/Grow.c
index 4ecb1d8..1a93391 100644
--- a/Grow.c
+++ b/Grow.c
@@ -530,6 +530,7 @@ int Grow_consistency_policy(char *devname, int fd, struct context *c, struct sha
 	char *subarray = NULL;
 	int ret = 0;
 	char container_dev[PATH_MAX];
+	char buf[20];
 
 	if (s->consistency_policy != CONSISTENCY_POLICY_RESYNC &&
 	    s->consistency_policy != CONSISTENCY_POLICY_PPL) {
@@ -577,6 +578,17 @@ int Grow_consistency_policy(char *devname, int fd, struct context *c, struct sha
 		goto free_info;
 	}
 
+	if (s->consistency_policy == CONSISTENCY_POLICY_PPL) {
+		if (sysfs_get_str(sra, NULL, "sync_action", buf, 20) <= 0) {
+			ret = 1;
+			goto free_info;
+		} else if (strcmp(buf, "reshape\n") == 0) {
+			pr_err("PPL cannot be enabled when reshape is in progress\n");
+			ret = 1;
+			goto free_info;
+		}
+	}
+
 	if (subarray) {
 		char *update;
 
-- 
1.8.3.1

Re: [PATCH] Grow: don't allow to enable PPL when reshape is in progress

[Jes Sorensen]

On 06/09/2017 10:20 AM, Tomasz Majchrzak wrote:
> Don't allow to enable PPL consistency policy when reshape is in progress.
> Current PPL implementation doesn't work when reshape is taking place.
> 
> Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
> ---
>   Grow.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)

Applied!

Thanks,
Jes