public inbox for linux-raid@vger.kernel.org
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: SandeepKsinha <sandeepksinha@gmail.com>
Cc: Linux RAID <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] md linear: Protecting mddev with rcu locks to avoid races
Date: Thu, 18 Jun 2009 09:38:29 +1000	[thread overview]
Message-ID: <19001.32373.993061.631031@notabene.brown> (raw)
In-Reply-To: message from SandeepKsinha on Wednesday June 17

On Wednesday June 17, sandeepksinha@gmail.com wrote:
> Hi Neil,
> 
> I am attaching the patch file as I am seeing some issues with
> copy-paste into the mail.
> 

Thanks.  Much better.

I possibly didn't explain myself properly when saying that the
rcu_read_lock needed to be taken out side of the call to which_dev.
The reason was that it returns a pointer which still needs to be
protected.  I possibly didn't for the code as it stood, but I wanted
to use call_rcu to free the old conf, so it makes sense to protect the
whole usage of the structure.

So I made that little change.  Then added a patch to free the old conf
with call_rcu.

It is all now pushed out and you can see the final version of this
patch at 

http://neil.brown.name/git?p=md;a=commitdiff;h=af11c397fd8835c70ec0bb777104e4ab98b2d660


Thanks,
NeilBrown

  reply	other threads:[~2009-06-17 23:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-06 15:24 [PATCH] md linear: Protecting mddev with rcu locks to avoid races in SandeepKsinha
2009-06-14 22:56 ` Neil Brown
2009-06-17  6:35   ` SandeepKsinha
2009-06-17  6:46     ` SandeepKsinha
2009-06-17  8:02       ` Sujit Karataparambil
2009-06-17  8:48         ` SandeepKsinha
2009-06-17  9:14           ` Sujit Karataparambil
2009-06-17  9:32             ` SandeepKsinha
2009-06-17  9:37               ` Sujit Karataparambil
2009-06-17 10:01                 ` Neil Brown
     [not found]                   ` <37d33d830906170315k4087d532nc2426879c2063fd7@mail.gmail.com>
2009-06-17 10:17                     ` SandeepKsinha
2009-06-17 23:38                       ` Neil Brown [this message]
2009-06-17  9:59       ` Neil Brown
2009-06-17  6:50     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19001.32373.993061.631031@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=sandeepksinha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox