From: "NeilBrown" <neilb@suse.de>
To: SandeepKsinha <sandeepksinha@gmail.com>
Cc: Linux RAID <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] md linear: Protecting mddev with rcu locks to avoid races in
Date: Wed, 17 Jun 2009 16:50:13 +1000 (EST) [thread overview]
Message-ID: <750ace456f740751a36dc62f891e2ea0.squirrel@neil.brown.name> (raw)
In-Reply-To: <37d33d830906162335j2dda043dn7e5c19d3b40de103@mail.gmail.com>
On Wed, June 17, 2009 4:35 pm, SandeepKsinha wrote:
>>
>> 2/ mddev->raid_disks should really be dereferenced before 'conf'.
>> Doing it the way you have done it, the 'raid_disks' value could be
>> larger than the value supported by the 'conf' so things could
>> go wrong.
>>
> Agreed. I hope you are referring to the case where a disk is in the
> process of being added to an array. Is that right ?
> Kindly confirm.
Yes, that is correct.
>> 4/ We don't need the rcu protection here as we hold ->reconfig_mutex
>> both in linear_add and linear_stop, so they cannot race.
>> Adding a comment to this effect might be a good idea though.
>>
>
> Fine. Shall do this as well.
>
> The new patch will follow soon.
>
Thanks!
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-06-17 6:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-06 15:24 [PATCH] md linear: Protecting mddev with rcu locks to avoid races in SandeepKsinha
2009-06-14 22:56 ` Neil Brown
2009-06-17 6:35 ` SandeepKsinha
2009-06-17 6:46 ` SandeepKsinha
2009-06-17 8:02 ` Sujit Karataparambil
2009-06-17 8:48 ` SandeepKsinha
2009-06-17 9:14 ` Sujit Karataparambil
2009-06-17 9:32 ` SandeepKsinha
2009-06-17 9:37 ` Sujit Karataparambil
2009-06-17 10:01 ` Neil Brown
[not found] ` <37d33d830906170315k4087d532nc2426879c2063fd7@mail.gmail.com>
2009-06-17 10:17 ` SandeepKsinha
2009-06-17 23:38 ` [PATCH] md linear: Protecting mddev with rcu locks to avoid races Neil Brown
2009-06-17 9:59 ` [PATCH] md linear: Protecting mddev with rcu locks to avoid races in Neil Brown
2009-06-17 6:50 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=750ace456f740751a36dc62f891e2ea0.squirrel@neil.brown.name \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=sandeepksinha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox