[Small Patch] for raidlib.c in raidtools-1.00.3

[Small Patch] for raidlib.c in raidtools-1.00.3

[Florian Schanda]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

Hi all,

I had some problems with raidtools, it gave me a wierd error saying

"/dev/md/0: Invalid argument"

After spending some time to fix it, I figured it would be a good idea to 
actually load the kernel module. ;)

To save save some trouble, I enhaced the error reporting for that particular 
function.


	- Florian Schanda

[-- Attachment #2: error-reporting.patch --]
[-- Type: text/x-diff, Size: 1036 bytes --]

--- raidlib.c.orig	Tue Feb 25 13:38:46 2003
+++ raidlib.c	Tue Feb 25 13:44:44 2003
@@ -149,20 +149,26 @@
 	    return 0;
 	}
 
-    if ((rc = ioctl (fd, RUN_ARRAY, (unsigned long)param))) {
-	    save_errno=errno;
-	    switch (save_errno) {
-	      case EBUSY:
-		fprintf(stderr,"%s: already running\n",dev);
-		break;
-		/* fall through */
-	      default:
-		perror (dev);
-	    }
-	    errno=save_errno;
-	    return 1;
-    }
-    return 0;
+	if ((rc = ioctl (fd, RUN_ARRAY, (unsigned long)param))) {
+		save_errno=errno;
+		switch (save_errno) {
+			case EBUSY:
+				fprintf(stderr,"%s: already running\n", dev);
+				break;
+			case EINVAL:
+				fprintf(stderr, "Error: EINVAL\n");
+				fprintf(stderr, "Request or argp is not valid.\n");
+				fprintf(stderr, "Are you *SURE* you compiled raid into the kernel, and loaded it?\n");
+				break;
+			/* fall through */
+			default:
+				perror (dev);
+		}
+		errno=save_errno;
+		return 1;
+	}
+	
+	return 0;
 }
 static int do_mdstart (int fd, char *dev, dev_t rdev) {
     int rc;

Re: [Small Patch] for raidlib.c in raidtools-1.00.3

[Stephen Lee]

Florian Schanda said:
> Hi all,
>
> I had some problems with raidtools, it gave me a wierd
> error saying
>
> "/dev/md/0: Invalid argument"
>
Shouldn't that be /dev/md0?

Stephen

Re: [Small Patch] for raidlib.c in raidtools-1.00.3

[Florian Schanda]

On Tuesday 25 February 2003 14:31, Stephen Lee wrote:
> Shouldn't that be /dev/md0?

Not if you're using devfs.

	- Florian Schanda