* [patch] md/dm-log: use PTR_ERR value instead of -ENOMEM
@ 2010-05-16 6:31 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-05-16 6:31 UTC (permalink / raw)
To: Neil Brown
Cc: Alasdair G Kergon, Mikulas Patocka, Nikanth Karthikesan,
Mike Snitzer, Martin K. Petersen, dm-devel, linux-raid
It's nicer to return the PTR_ERR() value instead of just returning
-ENOMEM. In the current code the PTR_ERR() value is always equal to
-ENOMEM so this doesn't actually affect anything, but still...
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
index 5a08be0..fbd80fb 100644
--- a/drivers/md/dm-log.c
+++ b/drivers/md/dm-log.c
@@ -455,7 +455,7 @@ static int create_log_context(struct dm_dirty_log *log, struct dm_target *ti,
r = PTR_ERR(lc->io_req.client);
DMWARN("couldn't allocate disk io client");
kfree(lc);
- return -ENOMEM;
+ return r;
}
lc->disk_header = vmalloc(buf_size);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-16 6:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-16 6:31 [patch] md/dm-log: use PTR_ERR value instead of -ENOMEM Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox