ANNOUNCE: mdadm 3.1.3 - A tool for managing Soft RAID under Linux

ANNOUNCE: mdadm 3.1.3 - A tool for managing Soft RAID under Linux

[Neil Brown]

I am pleased to announce the availability of
   mdadm version 3.1.3

It is available at the usual places:
   countrycode=xx.
   http://www.${countrycode}kernel.org/pub/linux/utils/raid/mdadm/
and via git at
   git://neil.brown.name/mdadm
   http://neil.brown.name/git?p=mdadm

This is a bugfix/stability release over 3.1.2

Significant changes are:
   -    mapfile now lives in a fixed location which default to
        /dev/.mdadm/map but can be changed at compile time.  This
	location is choses and most distros provide it during early
	boot and preserve it through.  As long a /dev exists and is
	writable, /dev/.mdadm will be created.
	Other files file communication with mdmon live here too.
	This fixes a bug reported by Debian and Gentoo users where
	udev would spin in early-boot.
   -    IMSM and DDF metadata will not be recognised on partitions
        as they should only be used on whole-disks.
   -    Various overflows causes by 2G drives have been addressed.
   -    A subarray of an IMSM contain can now be killed with
        --kill-subarray.  Also subarrays can be renamed with
	--update-subarray
   -    -If (or --incremental --fail) can be used  from udev to
        fail and remove from all arrays a device which has been
	unplugged from the system.  i.e. hot-unplug-support.
   -    "mdadm /dev/mdX --re-add missing" will look for any device
        that looks like it should be a member of /dev/mdX but isn't
	and will automatically --re-add it
   -    Now compile with -Wextra to get extra warnings.
   -    Lots of minor bug fixes, documentation improvements, etcc

This release is believed to be stable and you should feel free to
upgrade to 3.1.3

It is expected that the next release will be 3.2 with a number of new
features.  3.1.4 will only happen if important bugs show up before 3.2
is stable.

NeilBrown 6th August 2010

Re: ANNOUNCE: mdadm 3.1.3 - A tool for managing Soft RAID under Linux

[Mikael Abrahamsson]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 896 bytes --]

On Fri, 6 Aug 2010, Neil Brown wrote:

>
> I am pleased to announce the availability of
>   mdadm version 3.1.3

I get the following compile error:

gcc -Wall -Werror -Wstrict-prototypes -Wextra -Wno-unused-parameter -ggdb 
-DSendmail=\""/usr/sbin/sendmail -t"\" -DCONFFILE=\"/etc/mdadm.conf\" 
-DCONFFILE2=\"/etc/mdadm/mdadm.conf\" -DMAP_DIR=\"/dev/.mdadm\" 
-DMAP_FILE=\"map\" -DMDMON_DIR=\"/dev/.mdadm\" -DUSE_PTHREADS   -c -o 
super-intel.o super-intel.c
cc1: warnings being treated as errors
super-intel.c: In function ‘imsm_process_update’:
super-intel.c:5393: error: format not a string literal and no format arguments
super-intel.c:5393: error: format not a string literal and no format arguments
make: *** [super-intel.o] Error 1

This is on a ubuntu 10.04 system with their 2.6.32 kernel.

mdadm-3.1.2 compiles fine on the same system.

-- 
Mikael Abrahamsson    email: swmike@swm.pp.se

Re: ANNOUNCE: mdadm 3.1.3 - A tool for managing Soft RAID under Linux

[Neil Brown]

On Fri, 6 Aug 2010 09:08:03 +0200 (CEST)
Mikael Abrahamsson <swmike@swm.pp.se> wrote:

> On Fri, 6 Aug 2010, Neil Brown wrote:
> 
> >
> > I am pleased to announce the availability of
> >   mdadm version 3.1.3
> 
> I get the following compile error:
> 
> gcc -Wall -Werror -Wstrict-prototypes -Wextra -Wno-unused-parameter -ggdb 
> -DSendmail=\""/usr/sbin/sendmail -t"\" -DCONFFILE=\"/etc/mdadm.conf\" 
> -DCONFFILE2=\"/etc/mdadm/mdadm.conf\" -DMAP_DIR=\"/dev/.mdadm\" 
> -DMAP_FILE=\"map\" -DMDMON_DIR=\"/dev/.mdadm\" -DUSE_PTHREADS   -c -o 
> super-intel.o super-intel.c
> cc1: warnings being treated as errors
> super-intel.c: In function ‘imsm_process_update’:
> super-intel.c:5393: error: format not a string literal and no format arguments
> super-intel.c:5393: error: format not a string literal and no format arguments
> make: *** [super-intel.o] Error 1
> 
> This is on a ubuntu 10.04 system with their 2.6.32 kernel.
> 
> mdadm-3.1.2 compiles fine on the same system.
> 

Thanks for the report - I guess you have a newer compiler than me.

Below patch should fix it, or just
    make CWFLAGS=
as the code will still do the right thing.

NeilBrown

diff --git a/super-intel.c b/super-intel.c
index 4cebc8d..b880a74 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -5390,7 +5390,7 @@ static void imsm_process_update(struct supertype *st,
 			break;
 		}
 
-		snprintf((char *) dev->volume, MAX_RAID_SERIAL_LEN, name);
+		snprintf((char *) dev->volume, MAX_RAID_SERIAL_LEN, "%s", name);
 		super->updates_pending++;
 		break;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ANNOUNCE: mdadm 3.1.3 - A tool for managing Soft RAID under Linux

[Mikael Abrahamsson]

On Fri, 6 Aug 2010, Neil Brown wrote:

> Below patch should fix it, or just

It indeed does.

-- 
Mikael Abrahamsson    email: swmike@swm.pp.se