From: NeilBrown <neilb@suse.de>
To: Dan Carpenter <error27@gmail.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [patch] md/raid10: double lock typo in handle_read_error()
Date: Wed, 27 Jul 2011 20:59:54 +1000 [thread overview]
Message-ID: <20110727205954.4dc688b1@notabene.brown> (raw)
In-Reply-To: <20110727095202.GJ3824@shale.localdomain>
On Wed, 27 Jul 2011 12:52:02 +0300 Dan Carpenter <error27@gmail.com> wrote:
> This should be a spin_unlock_irq() instead of spin_lock_irq()
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 9214e08..8b29cd4 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -2117,7 +2117,7 @@ read_more:
> mbio->bi_phys_segments = 2;
> else
> mbio->bi_phys_segments++;
> - spin_lock_irq(&conf->device_lock);
> + spin_unlock_irq(&conf->device_lock);
> generic_make_request(bio);
> bio = NULL;
>
Thanks!
I haven't yet submitted the patch which introduced that bug, so I just fixed
the patch directly and credited you.
Thanks,
NeilBrown
prev parent reply other threads:[~2011-07-27 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 9:52 [patch] md/raid10: double lock typo in handle_read_error() Dan Carpenter
2011-07-27 10:59 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727205954.4dc688b1@notabene.brown \
--to=neilb@suse.de \
--cc=error27@gmail.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox