* [patch] md/raid10: double lock typo in handle_read_error()
@ 2011-07-27 9:52 Dan Carpenter
2011-07-27 10:59 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-07-27 9:52 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-raid
This should be a spin_unlock_irq() instead of spin_lock_irq()
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 9214e08..8b29cd4 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2117,7 +2117,7 @@ read_more:
mbio->bi_phys_segments = 2;
else
mbio->bi_phys_segments++;
- spin_lock_irq(&conf->device_lock);
+ spin_unlock_irq(&conf->device_lock);
generic_make_request(bio);
bio = NULL;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] md/raid10: double lock typo in handle_read_error()
2011-07-27 9:52 [patch] md/raid10: double lock typo in handle_read_error() Dan Carpenter
@ 2011-07-27 10:59 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-07-27 10:59 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-raid
On Wed, 27 Jul 2011 12:52:02 +0300 Dan Carpenter <error27@gmail.com> wrote:
> This should be a spin_unlock_irq() instead of spin_lock_irq()
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 9214e08..8b29cd4 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -2117,7 +2117,7 @@ read_more:
> mbio->bi_phys_segments = 2;
> else
> mbio->bi_phys_segments++;
> - spin_lock_irq(&conf->device_lock);
> + spin_unlock_irq(&conf->device_lock);
> generic_make_request(bio);
> bio = NULL;
>
Thanks!
I haven't yet submitted the patch which introduced that bug, so I just fixed
the patch directly and credited you.
Thanks,
NeilBrown
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-27 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-27 9:52 [patch] md/raid10: double lock typo in handle_read_error() Dan Carpenter
2011-07-27 10:59 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox