Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-raid@vger.kernel.org, shli@kernel.org
Subject: Re: [PATCH] raid5-ppl: PPL support for disks with write-back cache enabled
Date: Thu, 21 Dec 2017 10:19:02 +0100	[thread overview]
Message-ID: <20171221091902.GA26533@proton.igk.intel.com> (raw)
In-Reply-To: <201712210051.48XorsHT%fengguang.wu@intel.com>

On Thu, Dec 21, 2017 at 12:35:21AM +0800, kbuild test robot wrote:
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.15-rc4 next-20171220]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Tomasz-Majchrzak/raid5-ppl-PPL-support-for-disks-with-write-back-cache-enabled/20171220-181528
> reproduce:
>         # apt-get install sparse
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
>    633	
>    634			rcu_read_lock();
>  > 635			rdev = rcu_dereference(conf->disks[i].rdev);
>    636			if (rdev && test_bit(Faulty, &rdev->flags))
>    637				rdev = NULL;
>    638			rcu_read_unlock();

The warning from sparse is:

drivers/md/raid5-ppl.c:635:24: error: incompatible types in comparison expression (different address spaces)

There is the same warning for 20 other places in md raid5 code, everywhere
where rcu_dereference is used so I understand the probles is either in sparse
or in function implementation.

Tomek

  reply	other threads:[~2017-12-21  9:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 13:45 [PATCH] raid5-ppl: PPL support for disks with write-back cache enabled Tomasz Majchrzak
2017-12-20 16:35 ` kbuild test robot
2017-12-21  9:19   ` Tomasz Majchrzak [this message]
2017-12-21 19:30 ` Shaohua Li
2017-12-22 11:06   ` Tomasz Majchrzak
2017-12-22 18:09     ` Shaohua Li
2017-12-27  9:31       ` [PATCH v2] " Tomasz Majchrzak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221091902.GA26533@proton.igk.intel.com \
    --to=tomasz.majchrzak@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox