* [PATCH 1/1] Remove the config files in mdcheck_start|continue service
@ 2023-04-07 0:45 Xiao Ni
2023-04-10 15:51 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Xiao Ni @ 2023-04-07 0:45 UTC (permalink / raw)
To: jes; +Cc: neilb, linux-raid
We set MDADM_CHECK_DURATION in the mdcheck_start|continue.service files.
And mdcheck doesn't use any configs from the config file. So we can remove
the dependencies.
Signed-off-by: Xiao Ni <xni@redhat.com>
---
systemd/mdcheck_continue.service | 2 --
systemd/mdcheck_start.service | 2 --
2 files changed, 4 deletions(-)
diff --git a/systemd/mdcheck_continue.service b/systemd/mdcheck_continue.service
index 854317f11700..f576e0167f3c 100644
--- a/systemd/mdcheck_continue.service
+++ b/systemd/mdcheck_continue.service
@@ -12,6 +12,4 @@ ConditionPathExistsGlob = /var/lib/mdcheck/MD_UUID_*
[Service]
Type=oneshot
Environment="MDADM_CHECK_DURATION=6 hours"
-EnvironmentFile=-/run/sysconfig/mdadm
-ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --continue --duration ${MDADM_CHECK_DURATION}
diff --git a/systemd/mdcheck_start.service b/systemd/mdcheck_start.service
index 3bb3d130801f..f98e5c6f52d7 100644
--- a/systemd/mdcheck_start.service
+++ b/systemd/mdcheck_start.service
@@ -12,6 +12,4 @@ Wants=mdcheck_continue.timer
[Service]
Type=oneshot
Environment="MDADM_CHECK_DURATION=6 hours"
-EnvironmentFile=-/run/sysconfig/mdadm
-ExecStartPre=-/usr/lib/mdadm/mdadm_env.sh
ExecStart=/usr/share/mdadm/mdcheck --duration ${MDADM_CHECK_DURATION}
--
2.32.0 (Apple Git-132)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] Remove the config files in mdcheck_start|continue service
2023-04-07 0:45 [PATCH 1/1] Remove the config files in mdcheck_start|continue service Xiao Ni
@ 2023-04-10 15:51 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2023-04-10 15:51 UTC (permalink / raw)
To: Xiao Ni; +Cc: neilb, linux-raid
On 4/6/23 20:45, Xiao Ni wrote:
> We set MDADM_CHECK_DURATION in the mdcheck_start|continue.service files.
> And mdcheck doesn't use any configs from the config file. So we can remove
> the dependencies.
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
> systemd/mdcheck_continue.service | 2 --
> systemd/mdcheck_start.service | 2 --
> 2 files changed, 4 deletions(-)
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-10 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 0:45 [PATCH 1/1] Remove the config files in mdcheck_start|continue service Xiao Ni
2023-04-10 15:51 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox