From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, song@kernel.org, yukuai3@huawei.com, hch@lst.de
Cc: martin.petersen@oracle.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
hare@suse.de, Johannes.Thumshirn@wdc.com,
John Garry <john.g.garry@oracle.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH v3 2/6] block: Error an attempt to split an atomic write in bio_split()
Date: Thu, 31 Oct 2024 09:59:14 +0000 [thread overview]
Message-ID: <20241031095918.99964-3-john.g.garry@oracle.com> (raw)
In-Reply-To: <20241031095918.99964-1-john.g.garry@oracle.com>
This is disallowed.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
block/bio.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/block/bio.c b/block/bio.c
index 7a93724e4a49..07b971853768 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1749,6 +1749,10 @@ struct bio *bio_split(struct bio *bio, int sectors,
if (WARN_ON_ONCE(bio_op(bio) == REQ_OP_ZONE_APPEND))
return ERR_PTR(-EINVAL);
+ /* atomic writes cannot be split */
+ if (bio->bi_opf & REQ_ATOMIC)
+ return ERR_PTR(-EINVAL);
+
split = bio_alloc_clone(bio->bi_bdev, bio, gfp, bs);
if (!split)
return ERR_PTR(-ENOMEM);
--
2.31.1
next prev parent reply other threads:[~2024-10-31 9:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 9:59 [PATCH v3 0/6] bio_split() error handling rework John Garry
2024-10-31 9:59 ` [PATCH v3 1/6] block: Rework bio_split() return value John Garry
2024-11-05 7:21 ` Hannes Reinecke
2024-11-05 17:16 ` John Garry
2024-10-31 9:59 ` John Garry [this message]
2024-11-05 7:22 ` [PATCH v3 2/6] block: Error an attempt to split an atomic write in bio_split() Hannes Reinecke
2024-10-31 9:59 ` [PATCH v3 3/6] block: Handle bio_split() errors in bio_submit_split() John Garry
2024-11-05 7:23 ` Hannes Reinecke
2024-10-31 9:59 ` [PATCH v3 4/6] md/raid0: Handle bio_split() errors John Garry
2024-11-05 7:24 ` Hannes Reinecke
2024-10-31 9:59 ` [PATCH v3 5/6] md/raid1: " John Garry
2024-10-31 11:07 ` Yu Kuai
2024-11-05 7:26 ` Hannes Reinecke
2024-10-31 9:59 ` [PATCH v3 6/6] md/raid10: " John Garry
2024-10-31 11:11 ` Yu Kuai
2024-11-05 7:27 ` Hannes Reinecke
2024-11-07 6:49 ` [PATCH v3 0/6] bio_split() error handling rework John Garry
2024-11-07 6:49 ` John Garry
2024-11-07 18:27 ` Jens Axboe
2024-11-07 19:54 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031095918.99964-3-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=song@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox