From: Xiao Ni <xni@redhat.com>
To: linux-raid@vger.kernel.org
Cc: yukuai1@huaweicloud.com, song@kernel.org
Subject: [PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT
Date: Tue, 4 Mar 2025 17:09:50 +0800 [thread overview]
Message-ID: <20250304090950.18337-1-xni@redhat.com> (raw)
There is no need to print warn call trace. And it also can confuse
qe and mark test case failure.
Signed-off-by: Xiao Ni <xni@redhat.com>
---
drivers/md/raid10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 15b9ae5bf84d..0441691130c7 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1631,7 +1631,7 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio)
if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
return -EAGAIN;
- if (WARN_ON_ONCE(bio->bi_opf & REQ_NOWAIT)) {
+ if (bio->bi_opf & REQ_NOWAIT) {
bio_wouldblock_error(bio);
return 0;
}
--
2.32.0 (Apple Git-132)
next reply other threads:[~2025-03-04 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 9:09 Xiao Ni [this message]
2025-03-04 9:13 ` [PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT Paul Menzel
2025-03-04 9:36 ` Xiao Ni
2025-03-04 9:56 ` Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304090950.18337-1-xni@redhat.com \
--to=xni@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox