[PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT

[PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT

[Xiao Ni]

There is no need to print warn call trace. And it also can confuse
qe and mark test case failure.

Signed-off-by: Xiao Ni <xni@redhat.com>
---
 drivers/md/raid10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 15b9ae5bf84d..0441691130c7 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1631,7 +1631,7 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio)
 	if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
 		return -EAGAIN;
 
-	if (WARN_ON_ONCE(bio->bi_opf & REQ_NOWAIT)) {
+	if (bio->bi_opf & REQ_NOWAIT) {
 		bio_wouldblock_error(bio);
 		return 0;
 	}
-- 
2.32.0 (Apple Git-132)

Re: [PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT

[Paul Menzel]

Dear Xiao,


Thank you for your patch.


Am 04.03.25 um 10:09 schrieb Xiao Ni:
> There is no need to print warn call trace. And it also can confuse

Why is there no need?

> qe and mark test case failure.

What is *qe*?

> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
>   drivers/md/raid10.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 15b9ae5bf84d..0441691130c7 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -1631,7 +1631,7 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio)
>   	if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
>   		return -EAGAIN;
>   
> -	if (WARN_ON_ONCE(bio->bi_opf & REQ_NOWAIT)) {
> +	if (bio->bi_opf & REQ_NOWAIT) {
>   		bio_wouldblock_error(bio);
>   		return 0;
>   	}


Kind regards,

Paul

Re: [PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT

[Xiao Ni]

On Tue, Mar 4, 2025 at 5:14 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Xiao,
>
>
> Thank you for your patch.
>
>
> Am 04.03.25 um 10:09 schrieb Xiao Ni:
> > There is no need to print warn call trace. And it also can confuse
>
> Why is there no need?

Hi Paul

I use raid1 as a reference, there is no warning there. And why is
there need to give warning message?

>
> > qe and mark test case failure.
>
> What is *qe*?

quality engineering team. They check the result and report error if
the dmesg has calltrace(warning/error)

Regards
Xiao

>
> > Signed-off-by: Xiao Ni <xni@redhat.com>
> > ---
> >   drivers/md/raid10.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> > index 15b9ae5bf84d..0441691130c7 100644
> > --- a/drivers/md/raid10.c
> > +++ b/drivers/md/raid10.c
> > @@ -1631,7 +1631,7 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio)
> >       if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
> >               return -EAGAIN;
> >
> > -     if (WARN_ON_ONCE(bio->bi_opf & REQ_NOWAIT)) {
> > +     if (bio->bi_opf & REQ_NOWAIT) {
> >               bio_wouldblock_error(bio);
> >               return 0;
> >       }
>
>
> Kind regards,
>
> Paul
>

Re: [PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT

[Xiao Ni]

Please ignore this patch. It should use wait_barrier first before
returning the discard request with REQ_NOWATI to the upper layer.

Regards
Xiao

On Tue, Mar 4, 2025 at 5:10 PM Xiao Ni <xni@redhat.com> wrote:
>
> There is no need to print warn call trace. And it also can confuse
> qe and mark test case failure.
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
>  drivers/md/raid10.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 15b9ae5bf84d..0441691130c7 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -1631,7 +1631,7 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio)
>         if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
>                 return -EAGAIN;
>
> -       if (WARN_ON_ONCE(bio->bi_opf & REQ_NOWAIT)) {
> +       if (bio->bi_opf & REQ_NOWAIT) {
>                 bio_wouldblock_error(bio);
>                 return 0;
>         }
> --
> 2.32.0 (Apple Git-132)
>
>