Linux RAID subsystem development
 help / color / mirror / Atom feed
From: nenkov2004@gmail.com
To: linux-raid@vger.kernel.org, yukuai@fygo.io, song@kernel.org
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	magiclinan@didiglobal.com, xiao@kernel.org, neil@brown.name,
	agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
	bmarzins@redhat.com,
	syzbot+8b22a0459202f76b4096@syzkaller.appspotmail.com,
	Hristos Nenkov <nenkov2004@gmail.com>
Subject: [PATCH v2 1/2] dm raid: Clear MD_RECOVERY_WAIT on reshape setup failure
Date: Fri, 20 Nov 2026 12:17:56 +0100	[thread overview]
Message-ID: <20261120111757.4705-2-nenkov2004@gmail.com> (raw)
In-Reply-To: <20261120111757.4705-1-nenkov2004@gmail.com>

From: Hristos Nenkov <nenkov2004@gmail.com>

rs_start_reshape() sets MD_RECOVERY_WAIT to keep the sync thread
from running before the table reload. If setup, check_reshape() or
start_reshape() fails, raid_preresume() logs the error and continues
without a reshape. There is no reshape-related table reload to wait for.

Clear MD_RECOVERY_WAIT on those error paths. Keep the bit set when
reshape setup succeeds.

Suggested-by: Yu Kuai <yukuai@fygo.io>
Link: https://lore.kernel.org/r/4d13edef-f454-437b-8910-3a905697303e@fygo.io
Signed-off-by: Hristos Nenkov <nenkov2004@gmail.com>
---
 drivers/md/dm-raid.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index ac019a0f5..e132951f3 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -4004,7 +4004,7 @@ static int rs_start_reshape(struct raid_set *rs)
 
 	r = rs_setup_reshape(rs);
 	if (r)
-		return r;
+		goto clear_recovery_wait;
 
 	/*
 	 * Check any reshape constraints enforced by the personalility
@@ -4014,7 +4014,7 @@ static int rs_start_reshape(struct raid_set *rs)
 	r = pers->check_reshape(mddev);
 	if (r) {
 		rs->ti->error = "pers->check_reshape() failed";
-		return r;
+		goto clear_recovery_wait;
 	}
 
 	/*
@@ -4025,7 +4025,7 @@ static int rs_start_reshape(struct raid_set *rs)
 		r = pers->start_reshape(mddev);
 		if (r) {
 			rs->ti->error = "pers->start_reshape() failed";
-			return r;
+			goto clear_recovery_wait;
 		}
 	}
 
@@ -4037,6 +4037,10 @@ static int rs_start_reshape(struct raid_set *rs)
 	rs_update_sbs(rs);
 
 	return 0;
+
+clear_recovery_wait:
+	clear_bit(MD_RECOVERY_WAIT, &mddev->recovery);
+	return r;
 }
 
 static int raid_preresume(struct dm_target *ti)

  reply	other threads:[~2026-11-20 11:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6aec6738.059f5055.2712e4.0005.GAE@google.com>
2026-11-10  5:44 ` [PATCH] md/raid10: preserve recovery flags on reshape abort Hristos Nenkov
2026-11-20  7:05   ` yu kuai
2026-11-20 11:17     ` [PATCH v2 0/2] Fix recovery flags on failed RAID10 reshape nenkov2004
2026-11-20 11:17       ` nenkov2004 [this message]
2026-11-20 11:22         ` [PATCH v2 1/2] dm raid: Clear MD_RECOVERY_WAIT on reshape setup failure sashiko-bot
2026-11-20 11:17       ` [PATCH v2 2/2] md/raid10: Preserve recovery flags on reshape abort nenkov2004

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120111757.4705-2-nenkov2004@gmail.com \
    --to=nenkov2004@gmail.com \
    --cc=agk@redhat.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=magiclinan@didiglobal.com \
    --cc=mpatocka@redhat.com \
    --cc=neil@brown.name \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=syzbot+8b22a0459202f76b4096@syzkaller.appspotmail.com \
    --cc=xiao@kernel.org \
    --cc=yukuai@fygo.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox